[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-09-24 16:23:10
Message-ID: 20140924162310.6970.34201 () probe ! kde ! org
[Download RAW message or body]
--===============6933769778644395147==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 23, 2014, 11:22 a.m., David Edmundson wrote:
> > applets/binary-clock/package/contents/ui/configGeneral.qml, line 58
> > <https://git.reviewboard.kde.org/r/120325/diff/1/?file=314632#file314632line58>
> >
> > in general ColumnLayout is better than Columns
> > (from QtQuick.Layouts 1.1)
Fwiw, I can't make ColumnLayout dynamically relayout things when one of them changes \
height in animation while Column in the very same place just works...
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120325/#review67280
-----------------------------------------------------------
On Sept. 23, 2014, 12:56 a.m., Joseph Wenninger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120325/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 12:56 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, \
> but some sizing/dot sizeing issues exist in the panels. At least it is a start
> I'd like somebody to have a look at it to tell me, if I'm on the right way or if \
> I'm completely wrong
>
> Diffs
> -----
>
> applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975
> applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4
> applets/CMakeLists.txt 38751705f0b712ee8ce6861a7d437402be480873
> applets/binary-clock/CMakeLists.txt b42a6e76752af3cc800ad5455ba0678a18a0ce45
> applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION
> applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION
> applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION
> applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION
> applets/binary-clock/package/contents/ui/main.qml PRE-CREATION
> applets/binary-clock/plasma-applet-binaryclock.desktop \
> 10bd99b0518873f819ae89c9e9b9e09d9eb3490e applets/binary-clock/clockConfig.ui \
> 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 \
> applets/binary-clock/package/contents/config/config.qml PRE-CREATION \
> applets/binary-clock/package/contents/config/main.xml PRE-CREATION \
> applets/binary-clock/binaryclock.cpp 75c4548588ff15e2316dd1c2e888ad8c07f7f78b
> Diff: https://git.reviewboard.kde.org/r/120325/diff/
>
>
> Testing
> -------
>
> It works on the desktop, but the dots are too small in the panel
>
>
> Thanks,
>
> Joseph Wenninger
>
>
--===============6933769778644395147==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120325/">https://git.reviewboard.kde.org/r/120325/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 23rd, 2014, 11:22 a.m. CEST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120325/diff/1/?file=314632#file314632line58" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/binary-clock/package/contents/ui/configGeneral.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">58</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">Column</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in \
general ColumnLayout is better than Columns<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> (from QtQuick.Layouts \
1.1)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fwiw, I can't make ColumnLayout dynamically relayout things when one of \
them changes height in animation while Column in the very same place just \
works...</p></pre> <br />
<p>- Martin</p>
<br />
<p>On September 23rd, 2014, 12:56 a.m. CEST, Joseph Wenninger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Joseph Wenninger.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2014, 12:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">port of the kde4 c++ based binary clock to kf5/qml \
only. It works on the desktop, but some sizing/dot sizeing issues exist in the \
panels. At least it is a start</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd like somebody to \
have a look at it to tell me, if I'm on the right way or if I'm completely \
wrong</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It works on the desktop, but the dots are too small in \
the panel</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/binary-clock/binaryclock.h <span style="color: \
grey">(5ae83dfff9c473bd484b99d49330093b6e091975)</span></li>
<li>applets/binary-clock/Messages.sh <span style="color: \
grey">(40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4)</span></li>
<li>applets/CMakeLists.txt <span style="color: \
grey">(38751705f0b712ee8ce6861a7d437402be480873)</span></li>
<li>applets/binary-clock/CMakeLists.txt <span style="color: \
grey">(b42a6e76752af3cc800ad5455ba0678a18a0ce45)</span></li>
<li>applets/binary-clock/package/contents/ui/BinaryClock.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/Dot.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/DotColumn.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/configGeneral.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/plasma-applet-binaryclock.desktop <span style="color: \
grey">(10bd99b0518873f819ae89c9e9b9e09d9eb3490e)</span></li>
<li>applets/binary-clock/clockConfig.ui <span style="color: \
grey">(0c2cec7925dd9e1ff92d7cd9d99005dca20497b0)</span></li>
<li>applets/binary-clock/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/binary-clock/binaryclock.cpp <span style="color: \
grey">(75c4548588ff15e2316dd1c2e888ad8c07f7f78b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120325/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6933769778644395147==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic