[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120353: Add timezones i18n stuff
From: Lukáš Tinkl <lukas () kde ! org>
Date: 2014-09-24 14:55:36
Message-ID: 20140924145536.6970.57078 () probe ! kde ! org
[Download RAW message or body]
--===============0134100784601674701==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120353/#review67364
-----------------------------------------------------------
This should either be fixed in QTimezone or we can just use KLocale/KTimezone to get \
the stuff we need meanwhile, no need to reinvent the wheel. Users don't care
- Lukáš Tinkl
On Zář. 24, 2014, 2:02 odp., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120353/
> -----------------------------------------------------------
>
> (Updated Zář. 24, 2014, 2:02 odp.)
>
>
> Review request for Localization and Translation (l10n) and Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> So in Plasma 5 we're adding support for timezones into the clock applet. It's based \
> on QTimeZone and that uses IDs which are consisting of "Continent/City". Qt has no \
> accessor methods for getting the city of the given timezone so we're parsing the \
> timezone ID and using the part after "/" as the city and we display that in the UI. \
> We want those cities translated however so it can display eg. "Praha" instead of \
> "Prague" for Czech users. So I've created this helper class which has a dictionary \
> of timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure \
> where exactly to put it, I'd prefer KI18n framework but as we would like to have \
> this in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does \
> not (and probably will not) depend on KI18n 5.3.
> I'm adding the l10n group to the reviewers - guys can you please comment/+1 this?
>
> If this is deemed good enough, I'd like to also add the country and continent i18n \
> functions into that class afterwards.
>
> Diffs
> -----
>
> applets/digital-clock/plugin/timezonemodel.cpp PRE-CREATION
> applets/digital-clock/plugin/timezonesi18n.h PRE-CREATION
> applets/digital-clock/plugin/timezonesi18n.cpp PRE-CREATION
> applets/digital-clock/package/contents/ui/DigitalClock.qml 614e172
> applets/digital-clock/plugin/CMakeLists.txt 0590e6e
> applets/digital-clock/plugin/digitalclockplugin.cpp PRE-CREATION
> applets/digital-clock/plugin/timezonemodel.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120353/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============0134100784601674701==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120353/">https://git.reviewboard.kde.org/r/120353/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
should either be fixed in QTimezone or we can just use KLocale/KTimezone to get the \
stuff we need meanwhile, no need to reinvent the wheel. Users don't care</p></pre> \
<br />
<p>- Lukáš Tinkl</p>
<br />
<p>On září 24th, 2014, 2:02 odp. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n) and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Zář. 24, 2014, 2:02 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So in Plasma 5 we're adding support for timezones into \
the clock applet. It's based on QTimeZone and that uses IDs which are consisting of \
"Continent/City". Qt has no accessor methods for getting the city of the given \
timezone so we're parsing the timezone ID and using the part after "/" as the city \
and we display that in the UI.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">We want those cities \
translated however so it can display eg. "Praha" instead of "Prague" for Czech users. \
So I've created this helper class which has a dictionary of \
timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure \
where exactly to put it, I'd prefer KI18n framework but as we would like to have this \
in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does not (and \
probably will not) depend on KI18n 5.3.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm adding the l10n \
group to the reviewers - guys can you please comment/+1 this?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
this is deemed good enough, I'd like to also add the country and continent i18n \
functions into that class afterwards.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/plugin/timezonesi18n.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/plugin/timezonesi18n.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(614e172)</span></li>
<li>applets/digital-clock/plugin/CMakeLists.txt <span style="color: \
grey">(0590e6e)</span></li>
<li>applets/digital-clock/plugin/digitalclockplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/plugin/timezonemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120353/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0134100784601674701==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic