From kde-panel-devel  Sat Sep 13 10:17:55 2014
From: =?ISO-8859-1?Q?=C0lex?= Fiestas <afiestas () kde ! org>
Date: Sat, 13 Sep 2014 10:17:55 +0000
To: kde-panel-devel
Subject: Re: plasmashell never emits setStage('desktop');
Message-Id: <2103786.tkOKOQsX6y () minibad>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141060349225278
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============3554688414211313747=="


--===============3554688414211313747==
Content-Type: multipart/signed; boundary="nextPart2585068.fn2ISGcd5L"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart2585068.fn2ISGcd5L
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Saturday 13 September 2014 10:07:09 Marco Martin wrote:

> > Also this code could  use some refactoring... It is really really really
> > complex.
> 
> Not really, at least not more than it needs to be: is pretty simple: it
> keeps track of the applets that had the startupcompleted constraint called
> on them and on itself, emits the signal when everybody is.
> Signaling that the qml is ready and keeping track centrally that all
> containments everywhere, and all their applets have indeed their qml ready
> as well, has to pass trough quite long hoops, not much to be done around
> that.
Well for a newcomer it is, lots of huge methods, Containment being an Applet, 
Applet having special cases for Containments lots of friend classes etc.

I am not saying that all the logic inside is not needed, what I am saying is 
that for a newcomer trying to fix a bug the code is too complex and we might 
want to refactor it bit a bit if possible and when desirable.

Anyway, will try to hunt the bug down!
--nextPart2585068.fn2ISGcd5L
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABAgAGBQJUFBnXAAoJEGCsZ2zsJAWefrMP/3zCY15Q4DwPMvMFXDyOL9dv
3ArX+SmVSUuH3zcaH9lOqVOzqRGAaCXT2e7PORr6JSX4QjJ9+/vgtLTsVsje9hnt
bLI6oUSeiHOHJM7VvuuQgMNfaFJaMUEokp9GzL759WSWgPt4llvCniC5JW217ikW
bQHIYu+gh552XCxKsugn8MLHenSJjJOH5Eq+2aQd67zWK9wYpDdUDhNQagg4u1HI
IFzPm8n13+lO7tQXJtguJH8Q6OWkwLnmJ+DEj/ECi+zV00u6HJ45kDXjpuXkASmc
plZpjIQsopUV0Wvv8i1R9cMhWdQYpwt5hxrNOa4v/ylIL5HoKImcwW5ZBlPbGfLx
gQWR5l0tAw5M6K52llu3H9DHzwklhE9i4kzKl4pyfdx364f1WNPx03z8Anm7u/la
LQ3XldEZnT2HQoTySvKDBuCuNdFY4bBszlcVSl2MUKgB4+YqFFEsKqHYipInlpTC
chS+hg/PnptxBodpVJHPH3RVzdNXXQaW5uRPTKrNwW9CmljNmiHvz5pd1pIq2i23
CYFvGrcsvMWbpJ9cuZd5THcnuyHMNT62rmGh6jgdR4BcwcQ4tJPeRbWU+1OiNb3X
g55w11TwPoXsJfyZZ0GKCzjG79Okekfp4X52BpILw9Rd9BwFHkQtnOAnYpSge6Nh
IFBMZcUCKUubjME/PRBt
=8nSx
-----END PGP SIGNATURE-----

--nextPart2585068.fn2ISGcd5L--


--===============3554688414211313747==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============3554688414211313747==--