'Re: Review Request 119916: Make the notification popup higher when 3 actions are present'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119916: Make the notification popup higher when 3 actions are present
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-08-30 13:06:59
Message-ID: 20140830130659.14966.66846 () probe ! kde ! org
[Download RAW message or body]

--===============0628493148797813480==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119916/#review65546
-----------------------------------------------------------

I just pushed Review 119817 which you gave a Ship it weeks ago already. You need to \
rebase this then. I apologize for the inconvenience.

- Kai Uwe Broulik

On Aug. 23, 2014, 11:19 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119916/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2014, 11:19 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Since the port of the Button component to QQC Button, the button height cannot be \
> set anymore, therefore the height of the popup now needs to be higher when there \
> are three actions. 
> 
> Diffs
> -----
> 
> applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1 
> applets/notifications/plugin/notificationshelper.cpp 783c0e4 
> 
> Diff: https://git.reviewboard.kde.org/r/119916/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png
>  
> 
> Thanks,
> 
> Martin Klapetek
> 
> 

--===============0628493148797813480==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119916/">https://git.reviewboard.kde.org/r/119916/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
just pushed Review 119817 which you gave a Ship it weeks ago already. You need to \
rebase this then. I apologize for the inconvenience.</p></pre>  <br />

<p>- Kai Uwe Broulik</p>

<br />
<p>On August 23rd, 2014, 11:19 nachm. UTC, Martin Klapetek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated Aug. 23, 2014, 11:19 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since the port of the Button component to QQC Button, \
the button height cannot be set anymore, therefore the height of the popup now needs \
to be higher when there are three actions.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notifications/package/contents/ui/NotificationPopup.qml <span \
style="color: grey">(489fbd1)</span></li>

 <li>applets/notifications/plugin/notificationshelper.cpp <span style="color: \
grey">(783c0e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119916/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0628493148797813480==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 