From kde-panel-devel Sat Aug 30 13:04:47 2014 From: "Kai Uwe Broulik" Date: Sat, 30 Aug 2014 13:04:47 +0000 To: kde-panel-devel Subject: Re: Review Request 119817: Display notification popup at the top for top panel Message-Id: <20140830130447.14966.21729 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140940390419895 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3188852993156275599==" --===============3188852993156275599== Content-Type: multipart/alternative; boundary="===============3677671538755428288==" --===============3677671538755428288== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119817/ ----------------------------------------------------------- (Updated Aug. 30, 2014, 1:04 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description ------- This patch makes the notification popups appear at the top when used from a top panel Diffs ----- applets/notifications/package/contents/ui/Notifications.qml 9b492d9 applets/notifications/plugin/notificationshelper.h 0476952 applets/notifications/plugin/notificationshelper.cpp 783c0e4 Diff: https://git.reviewboard.kde.org/r/119817/diff/ Testing ------- Works as expected, when panel is moved around, popups re-position themselves if needed. File Attachments ---------------- Notifications at the top https://git.reviewboard.kde.org/media/uploaded/files/2014/08/17/97aea6b9-b71f-4787-9a9b-574b5c6e5bc4__toppopup.png Thanks, Kai Uwe Broulik --===============3677671538755428288== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119817/

This change has been marked as submitted.

Review request for Plasma.
By Kai Uwe Broulik.

Updated Aug. 30, 2014, 1:04 p.m.

Repository: plasma-workspace

Description 

This patch makes the notification popups appear at the top when used from a top panel

Testing 

Works as expected, when panel is moved around, popups re-position themselves if needed.

Diffs

  • applets/notifications/package/contents/ui/Notifications.qml (9b492d9)
  • applets/notifications/plugin/notificationshelper.h (0476952)
  • applets/notifications/plugin/notificationshelper.cpp (783c0e4)

View Diff

File Attachments

  • Notifications at the top
    		•
    --===============3677671538755428288==-- --===============3188852993156275599== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3188852993156275599==--