[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119993: Port KAuth actions in libksysguard
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-08-29 16:29:32
Message-ID: 20140829162932.11204.73017 () probe ! kde ! org
[Download RAW message or body]
--===============1374510626416247632==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119993/#review65523
-----------------------------------------------------------
Ship it!
Looks good. Minor comments
processcore/helper.cpp
<https://git.reviewboard.kde.org/r/119993/#comment45779>
why not just use the right enum value?
processui/ksysguardprocesslist.cpp
<https://git.reviewboard.kde.org/r/119993/#comment45780>
There should be pretty headers
- David Edmundson
On Aug. 29, 2014, 4:12 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119993/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 4:12 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: libksysguard
>
>
> Description
> -------
>
> that was one (vital imho ;-) feature missing compared to 4.x
>
>
> Diffs
> -----
>
> processui/ksysguardprocesslist.cpp 1651a0a
> processcore/CMakeLists.txt 31eee10
> processcore/helper.cpp 6c1f570
> processcore/processes_linux_p.cpp 65b8dfd
>
> Diff: https://git.reviewboard.kde.org/r/119993/diff/
>
>
> Testing
> -------
>
> ioscheduler, cpuscheduler, sendsignal, renice actions all work.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============1374510626416247632==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119993/">https://git.reviewboard.kde.org/r/119993/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good. Minor comments</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119993/diff/1/?file=308486#file308486line39" \
style="color: black; font-weight: bold; text-decoration: \
underline;">processcore/helper.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">37</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">errorR</span>eply</span><span class="p">.</span><span \
class="n">setErrorCode</span><span class="p">(</span><span class="mi"><span \
class="hl">1</span></span><span class="p"><span \
class="hl">)</span>;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">39</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">r</span>eply</span><span class="p">.</span><span \
class="n">setErrorCode</span><span class="p">(</span><span class="k"><span \
class="hl">static_cast</span></span><span class="o"><span \
class="hl"><</span></span><span class="n"><span \
class="hl">ActionReply</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">Error</span></span><span \
class="o"><span class="hl">></span></span><span class="p"><span \
class="hl">(</span></span><span class="mi"><span class="hl">1</span></span><span \
class="p"><span class="hl">))</span>;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
not just use the right enum value?</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119993/diff/1/?file=308488#file308488line51" \
style="color: black; font-weight: bold; text-decoration: \
underline;">processui/ksysguardprocesslist.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <kauthaction.h></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There \
should be pretty headers</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On August 29th, 2014, 4:12 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 4:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">that was one (vital imho ;-) feature missing compared \
to 4.x</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ioscheduler, cpuscheduler, sendsignal, renice actions \
all work.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>processui/ksysguardprocesslist.cpp <span style="color: \
grey">(1651a0a)</span></li>
<li>processcore/CMakeLists.txt <span style="color: grey">(31eee10)</span></li>
<li>processcore/helper.cpp <span style="color: grey">(6c1f570)</span></li>
<li>processcore/processes_linux_p.cpp <span style="color: \
grey">(65b8dfd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119993/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1374510626416247632==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic