'Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-08-29 13:00:59
Message-ID: 20140829130059.11205.97967 () probe ! kde ! org
[Download RAW message or body]

--===============4599001557353786358==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119990/
-----------------------------------------------------------

Review request for Plasma.

Repository: libksysguard

Description
-------

Since libksysguard probably aims to be a framework, the libraries should have \
respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. Solves \
conflicts with KDE 4.

Diffs
-----

  ksgrd/CMakeLists.txt 64ad24a 
  lsofui/CMakeLists.txt 2b0c8ac 
  processcore/CMakeLists.txt 31eee10 
  processui/CMakeLists.txt 150e198 
  signalplotter/CMakeLists.txt 67aa8bb 

Diff: https://git.reviewboard.kde.org/r/119990/diff/

Testing
-------

Builds, installs, libraries are called libKF5*.so, includes in \
/usr/include/KF5/KSysGuard/

Thanks,

Dan Vrátil

--===============4599001557353786358==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119990/">https://git.reviewboard.kde.org/r/119990/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Dan Vrátil.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since libksysguard probably aims to be a framework, \
the libraries should have respective names and includes should be installed to \
KF5_INCLUE_INSTALL_DIR. Solves conflicts with KDE 4.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds, installs, libraries are called libKF5*.so, \
includes in /usr/include/KF5/KSysGuard/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksgrd/CMakeLists.txt <span style="color: grey">(64ad24a)</span></li>

 <li>lsofui/CMakeLists.txt <span style="color: grey">(2b0c8ac)</span></li>

 <li>processcore/CMakeLists.txt <span style="color: grey">(31eee10)</span></li>

 <li>processui/CMakeLists.txt <span style="color: grey">(150e198)</span></li>

 <li>signalplotter/CMakeLists.txt <span style="color: grey">(67aa8bb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119990/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4599001557353786358==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 