[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119984: more plasmashell code cleaning
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-08-29 9:49:58
Message-ID: 20140829094958.11205.20593 () probe ! kde ! org
[Download RAW message or body]
--===============1446909828976088877==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119984/#review65470
-----------------------------------------------------------
shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/119984/#comment45734>
KScreen::Output* ShellCorona -> KScreen::Output *ShellCorona
(or the other way around and then fix the two methods above
shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/119984/#comment45733>
KScreen::Output* output -> KScreen::Output *output
- Martin Klapetek
On Aug. 29, 2014, 9:43 a.m., Aaron J. Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119984/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 9:43 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Three commits that clean up some code warts in plasmashell.
>
>
> Diffs
> -----
>
> shell/main.cpp bb63bdc85ff2a003fa4a5c4e2320383db98da087
> shell/shellcorona.h d559fcdc99c0066d552e013d3fea249147f50b5f
> shell/shellcorona.cpp 84442ae60cf0f576a077e770ceae82a17721a456
>
> Diff: https://git.reviewboard.kde.org/r/119984/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron J. Seigo
>
>
--===============1446909828976088877==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119984/">https://git.reviewboard.kde.org/r/119984/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119984/diff/1/?file=308169#file308169line868" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/shellcorona.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">781</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">KScreen</span><span class="o">::</span><span class="n">Output</span><span \
class="o">*</span> <span class="n">ShellCorona</span><span class="o">::</span><span \
class="n">findPrimaryOutput</span><span class="p">()</span> <span \
class="k">const</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KScreen::Output* ShellCorona -> KScreen::Output *ShellCorona</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(or the other way around and then fix the two methods above</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119984/diff/1/?file=308169#file308169line870" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/shellcorona.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">783</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span> <span class="p">(</span><span class="n">KScreen</span><span \
class="o">::</span><span class="n">Output</span><span class="o">*</span> <span \
class="n">output</span><span class="p">,</span> <span \
class="n">m_screenConfiguration</span><span class="o">-></span><span \
class="n">connectedOutputs</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KScreen::Output* output -> KScreen::Output *output</p></pre> </div>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On August 29th, 2014, 9:43 a.m. CEST, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 9:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Three commits that clean up some code warts in \
plasmashell.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/main.cpp <span style="color: \
grey">(bb63bdc85ff2a003fa4a5c4e2320383db98da087)</span></li>
<li>shell/shellcorona.h <span style="color: \
grey">(d559fcdc99c0066d552e013d3fea249147f50b5f)</span></li>
<li>shell/shellcorona.cpp <span style="color: \
grey">(84442ae60cf0f576a077e770ceae82a17721a456)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119984/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1446909828976088877==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic