From kde-panel-devel Thu Aug 28 12:42:48 2014 From: "Hrvoje Senjan" Date: Thu, 28 Aug 2014 12:42:48 +0000 To: kde-panel-devel Subject: Re: Review Request 119964: Avoid dlopening plasmaadapter's devel symlink Message-Id: <20140828124248.11204.89579 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140922978929519 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3720987428438777607==" --===============3720987428438777607== Content-Type: multipart/alternative; boundary="===============7685032367724457932==" --===============7685032367724457932== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119964/ ----------------------------------------------------------- (Updated Aug. 28, 2014, 12:42 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Bugs: 335904 http://bugs.kde.org/show_bug.cgi?id=335904 Repository: plasma-mediacenter Description ------- Some distro's have PMC splitted to main and devel subpackage, in that case the lib to dlopen was not available to users w/o devel package installed, and made the bug exposed to them. Diffs ----- CMakeLists.txt 0f8138a config-plasma-mediacenter.h.cmake PRE-CREATION libs/mediacenter/CMakeLists.txt 76578fc libs/plasmaadapter/CMakeLists.txt 18059ce shells/newshell/CMakeLists.txt 287d780 shells/newshell/mainwindow.cpp 9350f5c Diff: https://git.reviewboard.kde.org/r/119964/diff/ Testing ------- builds + resolves the bug Thanks, Hrvoje Senjan --===============7685032367724457932== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119964/

This change has been marked as submitted.

Review request for Plasma.
By Hrvoje Senjan.

Updated Aug. 28, 2014, 12:42 p.m.

Bugs: 335904
Repository: plasma-mediacenter

Description 

Some distro's have PMC splitted to main and devel subpackage, in that case the lib to dlopen was not available to users w/o devel package installed, and made the bug exposed to them.

Testing 

builds + resolves the bug

Diffs

  • CMakeLists.txt (0f8138a)
  • config-plasma-mediacenter.h.cmake (PRE-CREATION)
  • libs/mediacenter/CMakeLists.txt (76578fc)
  • libs/plasmaadapter/CMakeLists.txt (18059ce)
  • shells/newshell/CMakeLists.txt (287d780)
  • shells/newshell/mainwindow.cpp (9350f5c)

View Diff
--===============7685032367724457932==-- --===============3720987428438777607== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3720987428438777607==--