[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119964: Avoid dlopening plasmaadapter's devel symlink
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2014-08-28 12:31:48
Message-ID: 20140828123148.11204.11266 () probe ! kde ! org
[Download RAW message or body]
--===============7403469009476523085==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119964/#review65427
-----------------------------------------------------------
Ship it!
Ship It!
- Bhushan Shah
On Aug. 28, 2014, 11:09 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119964/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 11:09 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 335904
> http://bugs.kde.org/show_bug.cgi?id=335904
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Some distro's have PMC splitted to main and devel subpackage, in that case the lib \
> to dlopen was not available to users w/o devel package installed, and made the bug \
> exposed to them.
>
> Diffs
> -----
>
> CMakeLists.txt 0f8138a
> config-plasma-mediacenter.h.cmake PRE-CREATION
> libs/mediacenter/CMakeLists.txt 76578fc
> libs/plasmaadapter/CMakeLists.txt 18059ce
> shells/newshell/CMakeLists.txt 287d780
> shells/newshell/mainwindow.cpp 9350f5c
>
> Diff: https://git.reviewboard.kde.org/r/119964/diff/
>
>
> Testing
> -------
>
> builds + resolves the bug
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============7403469009476523085==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119964/">https://git.reviewboard.kde.org/r/119964/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Bhushan Shah</p>
<br />
<p>On August 28th, 2014, 11:09 a.m. IST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2014, 11:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=335904">335904</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Some distro's have PMC splitted to main and devel \
subpackage, in that case the lib to dlopen was not available to users w/o devel \
package installed, and made the bug exposed to them.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds + resolves the bug</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0f8138a)</span></li>
<li>config-plasma-mediacenter.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(76578fc)</span></li>
<li>libs/plasmaadapter/CMakeLists.txt <span style="color: \
grey">(18059ce)</span></li>
<li>shells/newshell/CMakeLists.txt <span style="color: grey">(287d780)</span></li>
<li>shells/newshell/mainwindow.cpp <span style="color: grey">(9350f5c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119964/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7403469009476523085==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic