[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119967: Fix systemloadviewer monitorType settings
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-08-28 12:03:37
Message-ID: 20140828120337.11204.72790 () probe ! kde ! org
[Download RAW message or body]
--===============1331762628866817616==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119967/#review65420
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Aug. 28, 2014, 8:23 a.m., Martin Yrjölä wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119967/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 8:23 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Fix systemloadviewer monitorType settings
>
> The third revision of the port broke the changing of monitor type through settings, \
> it slipped past me because the setting worked when restarting plasmashell.
>
> Diffs
> -----
>
> applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml \
> 403c01cb93d350e341babb6830277eedd7f06a6c
> Diff: https://git.reviewboard.kde.org/r/119967/diff/
>
>
> Testing
> -------
>
> Changing between Bar and Circular monitor types in the plasmoid settings works now \
> as expected.
>
> Thanks,
>
> Martin Yrjölä
>
>
--===============1331762628866817616==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119967/">https://git.reviewboard.kde.org/r/119967/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On August 28th, 2014, 8:23 a.m. UTC, Martin Yrjölä wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Yrjölä.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2014, 8:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix systemloadviewer monitorType settings</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The third revision of the port broke the changing of monitor type through \
settings, it slipped past me because the setting worked when restarting \
plasmashell.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changing between Bar and Circular monitor types in the \
plasmoid settings works now as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml \
<span style="color: grey">(403c01cb93d350e341babb6830277eedd7f06a6c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119967/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1331762628866817616==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic