[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119965: rely on shell package to create the interactive console interface
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2014-08-28 9:53:38
Message-ID: 20140828095338.11204.54107 () probe ! kde ! org
[Download RAW message or body]
--===============6477915446202483835==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119965/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 9:53 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This move the KTextEditor dependency out of plasmashell and into a QML component which uses it. \
This allows plasmashell to carry fewer dependencies while at *runtime* be able to appropriately \
address different form factors. It also moves the responsibility for showing the interactive \
scripting console to the shell package which can elect not to provide such a thing, allowing \
the shell to determine whether there is a console or not and what form it takes.
Note that this also moves the widgetexplorer into a common components directory where both it \
and the interactive console are put into a single plugin. This may want to be changed in future \
to allow separate plugins to be shipped, but this is better for performance and until shown \
necessary may as well be this way.
This relies on a one-liner patch to plasma-framework adding the interactive console QML file \
key to the shell package structure. I'm not going to bother with a review request for that, but \
will push it before pushing this.
Diffs
-----
CMakeLists.txt 6642d780aabe1777cb0457bb9b04e42c72358c9f
components/BatteryIcon.qml
components/CMakeLists.txt 07c48745652d7ec02147c2314ca08766a386f6b2
components/qmldir
components/shellprivate/CMakeLists.txt PRE-CREATION
components/shellprivate/Messages.sh PRE-CREATION
shell/CMakeLists.txt 4b1dd664c4eae6dbb1832c54411140ce7c11038d
shell/interactiveconsole.h d3af64bf456de60140f8a8efd4a4655ba5c6b6dd
shell/interactiveconsole.cpp 7096033a3076472a969b9bb19c43053d5e9977f8
shell/scripting/desktopscriptengine.h dd097d228b3982910346fe6f07412fd0137fc372
shell/scripting/desktopscriptengine.cpp 37d138744dd2b56e6b34cdd20f1eef5c79361a40
shell/scripting/scriptengine.h ffb0cbfb435d224f48cd715b66e94449114642db
shell/widgetexplorer/kcategorizeditemsviewmodels_p.h
shell/widgetexplorer/openwidgetassistant.cpp
shell/widgetexplorer/openwidgetassistant_p.h
shell/widgetexplorer/plasmaappletitemmodel.cpp
shell/widgetexplorer/plasmaappletitemmodel_p.h
shell/widgetexplorer/plasmoids.knsrc
shell/widgetexplorer/qmldir d808b18cfea863d6910df0cb922eb8e6e1c2bda9
shell/widgetexplorer/widgetexplorer.h
shell/widgetexplorer/widgetexplorer.cpp
shell/widgetexplorer/widgetexplorerplugin.h 3ee262e52d16feab35999c7963fc06b8653347a0
shell/widgetexplorer/widgetexplorerplugin.cpp f21178beb7279a851c4637fdc66d382d97f1bab9
shell/scripting/scriptengine.cpp 4db966f81d2cdaade21b07165ce6bfdd411c2366
shell/shellcorona.h b032803fe7286ba007a47a80065c6fbbb40a9709
shell/shellcorona.cpp c5447c24a2de5f42cda978e5690a210e15d80b76
shell/widgetexplorer/CMakeLists.txt dd0ea97045417245ac0b2c1a870147f2ff34e4ec
shell/widgetexplorer/Messages.sh 3beeea4b3eae941ad88b66ec9af667915b66e950
shell/widgetexplorer/kcategorizeditemsviewmodels.cpp
Diff: https://git.reviewboard.kde.org/r/119965/diff/
Testing
-------
Run with a shell package with InteractiveConsole.qml, used the console to run scripts, opened \
and closed it, etc.
Thanks,
Aaron J. Seigo
--===============6477915446202483835==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119965/">https://git.reviewboard.kde.org/r/119965/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2014, 9:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This move the \
KTextEditor dependency out of plasmashell and into a QML component which uses it. This allows \
plasmashell to carry fewer dependencies while at <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">runtime</em> be able to \
appropriately address different form factors. It also moves the responsibility for showing the \
interactive scripting console to the shell package which can elect not to provide such a thing, \
allowing the shell to determine whether there is a console or not and what form it takes.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Note that this also moves the widgetexplorer into a common components directory where \
both it and the interactive console are put into a single plugin. This may want to be changed \
in future to allow separate plugins to be shipped, but this is better for performance and until \
shown necessary may as well be this way.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This relies on a one-liner patch \
to plasma-framework adding the interactive console QML file key to the shell package structure. \
I'm not going to bother with a review request for that, but will push it before pushing \
this.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Run with a \
shell package with InteractiveConsole.qml, used the console to run scripts, opened and closed \
it, etc.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(6642d780aabe1777cb0457bb9b04e42c72358c9f)</span></li>
<li>components/BatteryIcon.qml <span style="color: grey">()</span></li>
<li>components/CMakeLists.txt <span style="color: \
grey">(07c48745652d7ec02147c2314ca08766a386f6b2)</span></li>
<li>components/qmldir <span style="color: grey">()</span></li>
<li>components/shellprivate/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/shellprivate/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/CMakeLists.txt <span style="color: \
grey">(4b1dd664c4eae6dbb1832c54411140ce7c11038d)</span></li>
<li>shell/interactiveconsole.h <span style="color: \
grey">(d3af64bf456de60140f8a8efd4a4655ba5c6b6dd)</span></li>
<li>shell/interactiveconsole.cpp <span style="color: \
grey">(7096033a3076472a969b9bb19c43053d5e9977f8)</span></li>
<li>shell/scripting/desktopscriptengine.h <span style="color: \
grey">(dd097d228b3982910346fe6f07412fd0137fc372)</span></li>
<li>shell/scripting/desktopscriptengine.cpp <span style="color: \
grey">(37d138744dd2b56e6b34cdd20f1eef5c79361a40)</span></li>
<li>shell/scripting/scriptengine.h <span style="color: \
grey">(ffb0cbfb435d224f48cd715b66e94449114642db)</span></li>
<li>shell/widgetexplorer/kcategorizeditemsviewmodels_p.h <span style="color: \
grey">()</span></li>
<li>shell/widgetexplorer/openwidgetassistant.cpp <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/openwidgetassistant_p.h <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/plasmaappletitemmodel.cpp <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/plasmaappletitemmodel_p.h <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/plasmoids.knsrc <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/qmldir <span style="color: \
grey">(d808b18cfea863d6910df0cb922eb8e6e1c2bda9)</span></li>
<li>shell/widgetexplorer/widgetexplorer.h <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/widgetexplorer.cpp <span style="color: grey">()</span></li>
<li>shell/widgetexplorer/widgetexplorerplugin.h <span style="color: \
grey">(3ee262e52d16feab35999c7963fc06b8653347a0)</span></li>
<li>shell/widgetexplorer/widgetexplorerplugin.cpp <span style="color: \
grey">(f21178beb7279a851c4637fdc66d382d97f1bab9)</span></li>
<li>shell/scripting/scriptengine.cpp <span style="color: \
grey">(4db966f81d2cdaade21b07165ce6bfdd411c2366)</span></li>
<li>shell/shellcorona.h <span style="color: \
grey">(b032803fe7286ba007a47a80065c6fbbb40a9709)</span></li>
<li>shell/shellcorona.cpp <span style="color: \
grey">(c5447c24a2de5f42cda978e5690a210e15d80b76)</span></li>
<li>shell/widgetexplorer/CMakeLists.txt <span style="color: \
grey">(dd0ea97045417245ac0b2c1a870147f2ff34e4ec)</span></li>
<li>shell/widgetexplorer/Messages.sh <span style="color: \
grey">(3beeea4b3eae941ad88b66ec9af667915b66e950)</span></li>
<li>shell/widgetexplorer/kcategorizeditemsviewmodels.cpp <span style="color: \
grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119965/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6477915446202483835==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic