'Re: Review Request 119966: add an InteractiveConsole.qml'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119966: add an InteractiveConsole.qml
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-08-28 8:58:21
Message-ID: 20140828085821.11205.29533 () probe ! kde ! org
[Download RAW message or body]

--===============0433702844604151330==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119966/#review65401
-----------------------------------------------------------

Ship it!

Ship it! (after 119965)

- Marco Martin

On Aug. 28, 2014, 8:19 a.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119966/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 8:19 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This adds an InteractiveConsole.qml file to go along with Review Request #119965. \
> The main discussion point is what the name of the QML file should be and its \
> location in the shell package. I have no particular opinion one way or the other, \
> so I'll be looking to whoever maintains that particular design to say either \
> "that's fine where it is in the patch" or give a different location that I will \
> move it to. 
> 
> Diffs
> -----
> 
> desktoppackage/contents/InteractiveConsole.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119966/diff/
> 
> 
> Testing
> -------
> 
> Tested in plasmashell.
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
> 

--===============0433702844604151330==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119966/">https://git.reviewboard.kde.org/r/119966/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
it! (after 119965)</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On August 28th, 2014, 8:19 a.m. UTC, Aaron J. Seigo wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>

<p style="color: grey;"><i>Updated Aug. 28, 2014, 8:19 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds an InteractiveConsole.qml file to go along \
with Review Request #119965. The main discussion point is what the name of the QML \
file should be and its location in the shell package. I have no particular opinion \
one way or the other, so I'll be looking to whoever maintains that particular design \
to say either "that's fine where it is in the patch" or give a different location \
that I will move it to.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested in plasmashell.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/InteractiveConsole.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119966/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0433702844604151330==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 