From kde-panel-devel Wed Aug 27 17:02:33 2014 From: =?utf-8?b?TWFydGluIFlyasO2bMOk?= Date: Wed, 27 Aug 2014 17:02:33 +0000 To: kde-panel-devel Subject: Re: Review Request 119927: Port systemloadviewer plasmoid Message-Id: <20140827170233.11205.86759 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140915897605555 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0717644677380452829==" --===============0717644677380452829== Content-Type: multipart/alternative; boundary="===============4994944376347772028==" --===============4994944376347772028== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/ ----------------------------------------------------------- (Updated Aug. 27, 2014, 5:02 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and David Edmundson. Repository: kdeplasma-addons Description ------- Port systemloadviewer plasmoid It had a VDG makeover and now there's also circular monitors available in the options. There are regressions as well. These features aren't yet implemented: - Horizontal bar support - Individual monitors for each cpu Probably there are some optimizations to be done. I'm not really sure how I should handle the two types of monitors (bar, circular) correctly. Now I just hide the one that is not enabled in the options. Diffs ----- applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml PRE-CREATION applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 9324d4216e716b2156f5f084c8b4782a6dd84806 applets/systemloadviewer/systemloadviewer.h 9bbcf2305ef47dd8883600002a9b65954ba65a74 applets/systemloadviewer/systemloadviewer.cpp bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml PRE-CREATION applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml PRE-CREATION applets/systemloadviewer/package/contents/ui/GeneralSettings.qml PRE-CREATION applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION applets/systemloadviewer/package/contents/ui/CircularMonitor.qml PRE-CREATION applets/systemloadviewer/Messages.sh b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 applets/systemloadviewer/coloursconfig.ui 70a08afbaa204bb78865a545965210f3e2dfe42a applets/systemloadviewer/generalconfig.ui 2ae6d6540a12203e73bab5ca930da751f94bde22 applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 applets/systemloadviewer/CMakeLists.txt 6de867aa63e5102a5085667f8106ec09da2c4968 Diff: https://git.reviewboard.kde.org/r/119927/diff/ Testing ------- Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar monitor is not pixel perfect because of the edge roundings. I haven't been able to test if this plasmoid works with high DPI monitors. File Attachments ---------------- Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png Thanks, Martin Yrjölä --===============4994944376347772028== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/

This change has been marked as submitted.

Review request for Plasma and David Edmundson.
By Martin Yrjölä.

Updated Aug. 27, 2014, 5:02 p.m.

Repository: kdeplasma-addons

Description 

Port systemloadviewer plasmoid


It had a VDG makeover and now there's also circular monitors available in the options.


There are regressions as well. These features aren't yet implemented:

- Horizontal bar support

- Individual monitors for each cpu


Probably there are some optimizations to be done. I'm not really sure how I should handle the two types of monitors (bar, circular) correctly. Now I just hide the one that is not enabled in the options.

Testing 

Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar monitor is not pixel perfect because of the edge roundings. I haven't been able to test if this plasmoid works with high DPI monitors.

Diffs

  • applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (PRE-CREATION)
  • applets/systemloadviewer/plasma-applet-systemloadviewer.desktop (9324d4216e716b2156f5f084c8b4782a6dd84806)
  • applets/systemloadviewer/systemloadviewer.h (9bbcf2305ef47dd8883600002a9b65954ba65a74)
  • applets/systemloadviewer/systemloadviewer.cpp (bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f)
  • applets/systemloadviewer/package/contents/ui/ColorPicker.qml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/ui/GeneralSettings.qml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/config/main.xml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/ui/BarMonitor.qml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/ui/CircularMonitor.qml (PRE-CREATION)
  • applets/systemloadviewer/Messages.sh (b95833b3b5cf7865e72ed6b46e8dcd7848c599e1)
  • applets/systemloadviewer/TODO (210dcd76f02b2a8f62e2e7339d089c545a4fb112)
  • applets/systemloadviewer/coloursconfig.ui (70a08afbaa204bb78865a545965210f3e2dfe42a)
  • applets/systemloadviewer/generalconfig.ui (2ae6d6540a12203e73bab5ca930da751f94bde22)
  • applets/systemloadviewer/package/contents/config/config.qml (PRE-CREATION)
  • applets/CMakeLists.txt (ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099)
  • applets/systemloadviewer/CMakeLists.txt (6de867aa63e5102a5085667f8106ec09da2c4968)

View Diff

File Attachments

  • Screenshot
    		•
    --===============4994944376347772028==-- --===============0717644677380452829== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0717644677380452829==--