'Re: Review Request 119943: plasma windowed and associated runner back'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119943: plasma windowed and associated runner back
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-08-27 12:52:38
Message-ID: 20140827125238.11204.75304 () probe ! kde ! org
[Download RAW message or body]

--===============7771922347642867474==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65364
-----------------------------------------------------------

Ship it!

Ship It!

- David Edmundson

On Aug. 27, 2014, 12:45 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 12:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this is a rewrite of the plasma windowed shell and the associated runner, in order \
> to have plasmoids as mini applications. 
> 
> Diffs
> -----
> 
> runners/CMakeLists.txt fe4e322 
> runners/windowedwidgets/CMakeLists.txt ca31b29 
> runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 
> runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd 
> CMakeLists.txt 6642d78 
> plasma-windowed/CMakeLists.txt PRE-CREATION 
> plasma-windowed/main.cpp PRE-CREATION 
> plasma-windowed/plasma-windowed.desktop PRE-CREATION 
> plasma-windowed/plasmaquick/configview.h PRE-CREATION 
> plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION 
> plasma-windowed/plasmaquick/view.h PRE-CREATION 
> plasma-windowed/plasmawindowedcorona.h PRE-CREATION 
> plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION 
> plasma-windowed/plasmawindowedview.h PRE-CREATION 
> plasma-windowed/plasmawindowedview.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
> 
> 
> Testing
> -------
> 
> they correctly save and restore settings, it supports one plasmoid per type, window \
> geometries are been saved and restored as well. still missing a first default size \
> of the window coming from hints, but that will a bit more complicated (if possible \
> at all) 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============7771922347642867474==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119943/">https://git.reviewboard.kde.org/r/119943/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On August 27th, 2014, 12:45 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Aug. 27, 2014, 12:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is a rewrite of the plasma windowed shell and the \
associated runner, in order to have plasmoids as mini applications.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">they correctly save and restore settings, it supports \
one plasmoid per type, window geometries are been saved and restored as well.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> still missing a first default size of the window coming from hints, but \
that will a bit more complicated (if possible at all)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>runners/CMakeLists.txt <span style="color: grey">(fe4e322)</span></li>

 <li>runners/windowedwidgets/CMakeLists.txt <span style="color: \
grey">(ca31b29)</span></li>

 <li>runners/windowedwidgets/windowedwidgetsrunner.h <span style="color: \
grey">(13e9f43)</span></li>

 <li>runners/windowedwidgets/windowedwidgetsrunner.cpp <span style="color: \
grey">(4773bcd)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(6642d78)</span></li>

 <li>plasma-windowed/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasma-windowed.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmaquick/configview.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmaquick/shellpluginloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmaquick/view.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmawindowedcorona.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmawindowedview.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma-windowed/plasmawindowedview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119943/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7771922347642867474==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 