[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119943: plasma windowed and associated runner back
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-08-27 10:29:00
Message-ID: 20140827102900.11205.49319 () probe ! kde ! org
[Download RAW message or body]
--===============6277666128526584629==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > shell/main.cpp, line 43
> > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307797#file307797line43>
> >
> > this is already shipped?
> > your diffs are a bit messed up.
eww, yeah, doing diff from the wrong checkout
> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/main.cpp, line 69
> > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307784#file307784line69>
> >
> > this will include the applet name again, is that intentional?
args should be only the parameters from the second onwards?
> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/plasmawindowedview.cpp, line 131
> > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307792#file307792line131>
> >
> > on every mouseMove?
not mouse move, just window move, so dragging from the titlebar and similar (maybe \
still a bit too much, but writing on config without syncing should be fast i think?)
> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote:
> > plasma-windowed/plasmawindowedview.cpp, line 134
> > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307792#file307792line134>
> >
> > what's this for?
if the window is closed, both the window and the applet get deleted, they are \
considered closed (since the same process can open more than one window/applet) it \
does delete and not destroy to preserve the config
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65346
-----------------------------------------------------------
On Aug. 27, 2014, 9:32 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2014, 9:32 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> this is a rewrite of the plasma windowed shell and the associated runner, in order \
> to have plasmoids as mini applications.
>
> Diffs
> -----
>
> runners/windowedwidgets/CMakeLists.txt ca31b29
> runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43
> runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd
> shell/main.cpp 0d53bf5
> CMakeLists.txt 6642d78
> plasma-windowed/CMakeLists.txt PRE-CREATION
> plasma-windowed/main.cpp PRE-CREATION
> plasma-windowed/plasma-windowed.desktop PRE-CREATION
> plasma-windowed/plasmaquick/configview.h PRE-CREATION
> plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION
> plasma-windowed/plasmaquick/view.h PRE-CREATION
> plasma-windowed/plasmawindowedcorona.h PRE-CREATION
> plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION
> plasma-windowed/plasmawindowedview.h PRE-CREATION
> plasma-windowed/plasmawindowedview.cpp PRE-CREATION
> runners/CMakeLists.txt fe4e322
>
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
>
>
> Testing
> -------
>
> they correctly save and restore settings, it supports one plasmoid per type, window \
> geometries are been saved and restored as well. still missing a first default size \
> of the window coming from hints, but that will a bit more complicated (if possible \
> at all)
>
> Thanks,
>
> Marco Martin
>
>
--===============6277666128526584629==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119943/">https://git.reviewboard.kde.org/r/119943/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2014, 9:58 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/3/?file=307784#file307784line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">69</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">corona</span><span class="o">-></span><span \
class="n">loadApplet</span><span class="p">(</span><span class="n">parser</span><span \
class="p">.</span><span class="n">positionalArguments</span><span \
class="p">().</span><span class="n">first</span><span class="p">(),</span> <span \
class="n">args</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
will include the applet name again, is that intentional?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">args should be only the parameters from the second onwards?</p></pre> <br \
/>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2014, 9:58 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/3/?file=307792#file307792line131" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/plasmawindowedview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">131</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_applet</span><span class="o">-></span><span \
class="n">config</span><span class="p">().</span><span \
class="n">writeEntry</span><span class="p">(</span><span \
class="s">"geometry"</span><span class="p">,</span> <span \
class="n">QRect</span><span class="p">(</span><span class="n">position</span><span \
class="p">(),</span> <span class="n">size</span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on \
every mouseMove?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">not mouse move, just window move, so dragging from the titlebar and similar \
(maybe still a bit too much, but writing on config without syncing should be fast i \
think?)</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2014, 9:58 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/3/?file=307792#file307792line134" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/plasmawindowedview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">134</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">PlasmaWindowedView</span><span \
class="o">::</span><span class="n">hideEvent</span><span class="p">(</span><span \
class="n">QHideEvent</span> <span class="o">*</span><span class="n">ev</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">what's this for?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">if the window is closed, both the window and the applet get deleted, they \
are considered closed (since the same process can open more than one \
window/applet)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> it does delete and not destroy to preserve the \
config</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2014, 9:58 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/3/?file=307797#file307797line43" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
noMessageOutput(QtMsgType type, const char *msg)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">43</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if \
QT_VERSION >= QT_VERSION_CHECK(5, 4, 0)</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">43</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
is already shipped?<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> your diffs are a bit messed \
up.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">eww, yeah, doing diff from the wrong checkout</p></pre> <br />
<p>- Marco</p>
<br />
<p>On August 27th, 2014, 9:32 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2014, 9:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is a rewrite of the plasma windowed shell and the \
associated runner, in order to have plasmoids as mini applications.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">they correctly save and restore settings, it supports \
one plasmoid per type, window geometries are been saved and restored as well.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> still missing a first default size of the window coming from hints, but \
that will a bit more complicated (if possible at all)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/windowedwidgets/CMakeLists.txt <span style="color: \
grey">(ca31b29)</span></li>
<li>runners/windowedwidgets/windowedwidgetsrunner.h <span style="color: \
grey">(13e9f43)</span></li>
<li>runners/windowedwidgets/windowedwidgetsrunner.cpp <span style="color: \
grey">(4773bcd)</span></li>
<li>shell/main.cpp <span style="color: grey">(0d53bf5)</span></li>
<li>CMakeLists.txt <span style="color: grey">(6642d78)</span></li>
<li>plasma-windowed/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasma-windowed.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmaquick/configview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmaquick/shellpluginloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmaquick/view.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedcorona.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/CMakeLists.txt <span style="color: grey">(fe4e322)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119943/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6277666128526584629==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic