[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119943: plasma windowed and associated runner back
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2014-08-27 5:23:39
Message-ID: 20140827052339.11205.27836 () probe ! kde ! org
[Download RAW message or body]
--===============7161257398839370543==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119943/#review65328
-----------------------------------------------------------
plasma-windowed/main.cpp
<https://git.reviewboard.kde.org/r/119943/#comment45648>
Added twice
plasma-windowed/plasma-windowed.desktop
<https://git.reviewboard.kde.org/r/119943/#comment45649>
umm, AudioVideo?
plasma-windowed/plasmawindowedcorona.cpp
<https://git.reviewboard.kde.org/r/119943/#comment45650>
whitespace
plasma-windowed/plasmawindowedcorona.cpp
<https://git.reviewboard.kde.org/r/119943/#comment45651>
remove this debug message, or make at something specific.
- Bhushan Shah
On Aug. 26, 2014, 10:59 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119943/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 10:59 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> this is a rewrite of the plasma windowed shell and the associated runner, in order \
> to have plasmoids as mini applications.
>
> Diffs
> -----
>
> runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43
> runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd
> shell/main.cpp 0d53bf5
> CMakeLists.txt 6642d78
> plasma-windowed/CMakeLists.txt PRE-CREATION
> plasma-windowed/main.cpp PRE-CREATION
> plasma-windowed/plasma-windowed.desktop PRE-CREATION
> plasma-windowed/plasmaquick/configview.h PRE-CREATION
> plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION
> plasma-windowed/plasmaquick/view.h PRE-CREATION
> plasma-windowed/plasmawindowedcorona.h PRE-CREATION
> plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION
> plasma-windowed/plasmawindowedview.h PRE-CREATION
> plasma-windowed/plasmawindowedview.cpp PRE-CREATION
> runners/CMakeLists.txt fe4e322
> runners/windowedwidgets/CMakeLists.txt ca31b29
>
> Diff: https://git.reviewboard.kde.org/r/119943/diff/
>
>
> Testing
> -------
>
> they correctly save and restore settings, it supports one plasmoid per type, window \
> geometries are been saved and restored as well. still missing a first default size \
> of the window coming from hints, but that will a bit more complicated (if possible \
> at all)
>
> Thanks,
>
> Marco Martin
>
>
--===============7161257398839370543==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119943/">https://git.reviewboard.kde.org/r/119943/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/1/?file=307682#file307682line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">parser</span><span class="p">.</span><span \
class="n">addVersionOption</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added \
twice</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/1/?file=307683#file307683line11" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/plasma-windowed.desktop</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">11</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Categories=Qt;KDE;AudioVideo;</pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">umm, \
AudioVideo?</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/1/?file=307688#file307688line111" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/plasmawindowedcorona.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">111</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">createContainment</span><span class="p">(</span><span \
class="s">"empty"</span><span class="p">);</span><span class="ew"> \
</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">whitespace</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119943/diff/1/?file=307688#file307688line116" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma-windowed/plasmawindowedcorona.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="s">"here we are!"</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">remove this debug message, or make at something specific.</p></pre> </div>
</div>
<br />
<p>- Bhushan Shah</p>
<br />
<p>On August 26th, 2014, 10:59 p.m. IST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2014, 10:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is a rewrite of the plasma windowed shell and the \
associated runner, in order to have plasmoids as mini applications.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">they correctly save and restore settings, it supports \
one plasmoid per type, window geometries are been saved and restored as well.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> still missing a first default size of the window coming from hints, but \
that will a bit more complicated (if possible at all)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/windowedwidgets/windowedwidgetsrunner.h <span style="color: \
grey">(13e9f43)</span></li>
<li>runners/windowedwidgets/windowedwidgetsrunner.cpp <span style="color: \
grey">(4773bcd)</span></li>
<li>shell/main.cpp <span style="color: grey">(0d53bf5)</span></li>
<li>CMakeLists.txt <span style="color: grey">(6642d78)</span></li>
<li>plasma-windowed/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasma-windowed.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmaquick/configview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmaquick/shellpluginloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmaquick/view.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedcorona.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma-windowed/plasmawindowedview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/CMakeLists.txt <span style="color: grey">(fe4e322)</span></li>
<li>runners/windowedwidgets/CMakeLists.txt <span style="color: \
grey">(ca31b29)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119943/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7161257398839370543==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic