[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119927: Port systemloadviewer plasmoid
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-08-26 22:07:03
Message-ID: 20140826220703.11205.86969 () probe ! kde ! org
[Download RAW message or body]
--===============5839379332392600726==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/#review65326
-----------------------------------------------------------
Ship it!
applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml
<https://git.reviewboard.kde.org/r/119927/#comment45647>
For bonus points make it load nothing when it's not visible. It'll save a bit \
more.
applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml
<https://git.reviewboard.kde.org/r/119927/#comment45646>
personally I would have reduced it to.
source: switch( monitorType) {
case 0: ....
return "foo";
}
Bindings are generally better than functions as they can be optimised by the QML \
engine. not saying yours is wrong, but it's something to think about in future.
- David Edmundson
On Aug. 26, 2014, 9:43 p.m., Martin Yrjölä wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119927/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 9:43 p.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Port systemloadviewer plasmoid
>
> It had a VDG makeover and now there's also circular monitors available in the \
> options.
> There are regressions as well. These features aren't yet implemented:
> - Horizontal bar support
> - Individual monitors for each cpu
>
> Probably there are some optimizations to be done. I'm not really sure how I should \
> handle the two types of monitors (bar, circular) correctly. Now I just hide the one \
> that is not enabled in the options.
>
> Diffs
> -----
>
> applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099
> applets/systemloadviewer/CMakeLists.txt 6de867aa63e5102a5085667f8106ec09da2c4968
> applets/systemloadviewer/Messages.sh b95833b3b5cf7865e72ed6b46e8dcd7848c599e1
> applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112
> applets/systemloadviewer/coloursconfig.ui 70a08afbaa204bb78865a545965210f3e2dfe42a
> applets/systemloadviewer/generalconfig.ui 2ae6d6540a12203e73bab5ca930da751f94bde22
> applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION
> applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION
> applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION
> applets/systemloadviewer/systemloadviewer.h \
> 9bbcf2305ef47dd8883600002a9b65954ba65a74 \
> applets/systemloadviewer/systemloadviewer.cpp \
> bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f \
> applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml \
> PRE-CREATION applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml \
> PRE-CREATION applets/systemloadviewer/package/contents/ui/GeneralSettings.qml \
> PRE-CREATION applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml \
> PRE-CREATION applets/systemloadviewer/plasma-applet-systemloadviewer.desktop \
> 9324d4216e716b2156f5f084c8b4782a6dd84806 \
> applets/systemloadviewer/package/contents/ui/CircularMonitor.qml PRE-CREATION \
> applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION
> Diff: https://git.reviewboard.kde.org/r/119927/diff/
>
>
> Testing
> -------
>
> Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar monitor is \
> not pixel perfect because of the edge roundings. I haven't been able to test if \
> this plasmoid works with high DPI monitors.
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png
>
>
> Thanks,
>
> Martin Yrjölä
>
>
--===============5839379332392600726==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119927/">https://git.reviewboard.kde.org/r/119927/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119927/diff/2/?file=307731#file307731line33" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">Loader</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
bonus points make it load nothing when it's not visible. It'll save a bit \
more.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119927/diff/2/?file=307731#file307731line35" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">35</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">anchors.fill:</span> <span class="nx">parent</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">personally I would have reduced it to.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">source: switch( monitorType) {<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
case 0: .... <br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
return "foo";<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> }</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Bindings are generally better than functions as they \
can be optimised by the QML engine.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> not saying yours is \
wrong, but it's something to think about in future.</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On August 26th, 2014, 9:43 p.m. UTC, Martin Yrjölä wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Yrjölä.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2014, 9:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Port systemloadviewer plasmoid</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
had a VDG makeover and now there's also circular monitors available in the \
options.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There are regressions as well. These features aren't \
yet implemented:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
- Horizontal bar support<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
- Individual monitors for each cpu</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Probably there are some optimizations to be done. I'm \
not really sure how I should handle the two types of monitors (bar, circular) \
correctly. Now I just hide the one that is not enabled in the options.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works nicely on Air, Breeze light and Breeze dark \
Plasma themes. The Bar monitor is not pixel perfect because of the edge roundings. I \
haven't been able to test if this plasmoid works with high DPI monitors.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: \
grey">(ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099)</span></li>
<li>applets/systemloadviewer/CMakeLists.txt <span style="color: \
grey">(6de867aa63e5102a5085667f8106ec09da2c4968)</span></li>
<li>applets/systemloadviewer/Messages.sh <span style="color: \
grey">(b95833b3b5cf7865e72ed6b46e8dcd7848c599e1)</span></li>
<li>applets/systemloadviewer/TODO <span style="color: \
grey">(210dcd76f02b2a8f62e2e7339d089c545a4fb112)</span></li>
<li>applets/systemloadviewer/coloursconfig.ui <span style="color: \
grey">(70a08afbaa204bb78865a545965210f3e2dfe42a)</span></li>
<li>applets/systemloadviewer/generalconfig.ui <span style="color: \
grey">(2ae6d6540a12203e73bab5ca930da751f94bde22)</span></li>
<li>applets/systemloadviewer/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/BarMonitor.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/systemloadviewer.h <span style="color: \
grey">(9bbcf2305ef47dd8883600002a9b65954ba65a74)</span></li>
<li>applets/systemloadviewer/systemloadviewer.cpp <span style="color: \
grey">(bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/GeneralSettings.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/plasma-applet-systemloadviewer.desktop <span \
style="color: grey">(9324d4216e716b2156f5f084c8b4782a6dd84806)</span></li>
<li>applets/systemloadviewer/package/contents/ui/CircularMonitor.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ColorPicker.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119927/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145 \
-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5839379332392600726==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic