'Re: Review Request 119797: Show warning in lockscreen when capslock is enabled'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-08-25 17:26:14
Message-ID: 20140825172614.11205.94938 () probe ! kde ! org
[Download RAW message or body]

--===============1363120268719578948==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Aug. 25, 2014, 5:25 p.m., David Edmundson wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 119
> > <https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line119>
> > 
> > What was the point of this layout, there's only one item in it?

nevermind, I got confused.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65237
-----------------------------------------------------------

On Aug. 25, 2014, 3:10 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119797/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 3:10 p.m.)
> 
> 
> Review request for Plasma and Andrew Lake.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This will show a warning when capslock is enabled, like it used to in KDE 4 screen \
> locker. 
> 
> Diffs
> -----
> 
> ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
> lookandfeel/contents/components/UserSelect.qml 7b605b1 
> lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
> ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
> 
> Diff: https://git.reviewboard.kde.org/r/119797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
> 

--===============1363120268719578948==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119797/">https://git.reviewboard.kde.org/r/119797/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 25th, 2014, 5:25 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line119" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lookandfeel/contents/lockscreen/LockScreen.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="nx">ColumnLayout</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
was the point of this layout, there's only one item in it?</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">nevermind, I got confused.</p></pre> <br />

<p>- David</p>

<br />
<p>On August 25th, 2014, 3:10 p.m. UTC, Dan Vrátil wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Andrew Lake.</div>
<div>By Dan Vrátil.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2014, 3:10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This will show a warning when capslock is enabled, \
like it used to in KDE 4 screen locker.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(bb8a2bd)</span></li>

 <li>lookandfeel/contents/components/UserSelect.qml <span style="color: \
grey">(7b605b1)</span></li>

 <li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: \
grey">(ba95cb9)</span></li>

 <li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(f88d4d2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119797/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1363120268719578948==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 