'Re: Review Request 119928: bump required KF5 version to 5.2.0'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119928: bump required KF5 version to 5.2.0
From:       "Harald Sitter" <sitter () kde ! org>
Date:       2014-08-25 8:59:13
Message-ID: 20140825085913.11204.62079 () probe ! kde ! org
[Download RAW message or body]

--===============5115223897624903475==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119928/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 8:59 a.m.)

Review request for Plasma and Jonathan Riddell.

Repository: plasma-desktop

Description (updated)
-------

PlasmaQuick only got a version file last week, so 5.1.0 in fact will not be
able to match the requirements (i.e. PlasmaQuick 5.1 has version unknown as
far as cmake is concerned)

# To be pushed at a later time
can't be pushed because kf5 masters get a version bump before release, which is silly \
and in this particular case making plasma-desktop have invalid cmakelists because we \
can't bump the version until the new kf5 is out .....................

Diffs
-----

  CMakeLists.txt 52c896a573def5229ecc561f888c03fc84aeb7ab 

Diff: https://git.reviewboard.kde.org/r/119928/diff/

Testing
-------

Thanks,

Harald Sitter

--===============5115223897624903475==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119928/">https://git.reviewboard.kde.org/r/119928/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Jonathan Riddell.</div>
<div>By Harald Sitter.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2014, 8:59 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PlasmaQuick only got a version file last week, so \
5.1.0 in fact will not be<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> able to match the requirements (i.e. \
PlasmaQuick 5.1 has version unknown as<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> far as cmake is \
concerned)</p> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">To be pushed at a later \
time</h1> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">can't be pushed because kf5 masters get a version bump \
before release, which is silly and in this particular case making plasma-desktop have \
invalid cmakelists because we can't bump the version until the new kf5 is out \
.....................</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(52c896a573def5229ecc561f888c03fc84aeb7ab)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119928/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5115223897624903475==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 