[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119916: Make the notification popup higher when 3 actions are present
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-08-24 2:21:55
Message-ID: 20140824022155.8733.29489 () probe ! kde ! org
[Download RAW message or body]
--===============0252576051341710520==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119916/#review65108
-----------------------------------------------------------
Ship it!
One monsterous bug below. Make sure to fix it.
applets/notifications/package/contents/ui/NotificationPopup.qml
<https://git.reviewboard.kde.org/r/119916/#comment45486>
use a >= just for future proofing
applets/notifications/plugin/notificationshelper.cpp
<https://git.reviewboard.kde.org/r/119916/#comment45487>
= 0;
otherwise in non debug builds you're going to get garbage
- David Edmundson
On Aug. 23, 2014, 11:19 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119916/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2014, 11:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Since the port of the Button component to QQC Button, the button height cannot be \
> set anymore, therefore the height of the popup now needs to be higher when there \
> are three actions.
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1
> applets/notifications/plugin/notificationshelper.cpp 783c0e4
>
> Diff: https://git.reviewboard.kde.org/r/119916/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============0252576051341710520==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119916/">https://git.reviewboard.kde.org/r/119916/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One \
monsterous bug below. Make sure to fix it.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119916/diff/1/?file=307345#file307345line60" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/notifications/package/contents/ui/NotificationPopup.qml</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">60</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">height:</span> <span class="nb">Math</span><span class="p">.</span><span \
class="nx">round</span><span class="p">(</span><span class="mi">5</span> <span \
class="o">*</span> <span class="nx">units</span><span class="p">.</span><span \
class="nx">gridUnit</span><span class="p">)</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">60</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">height:</span> <span class="nx">actionsRepeater</span><span \
class="p">.</span><span class="nx">model</span><span class="p">.</span><span \
class="nx">length</span> <span class="o">==</span> <span class="mi">3</span> <span \
class="o">?</span> <span class="nb">Math</span><span class="p">.</span><span \
class="nx">round</span><span class="p">(</span><span class="mi">6</span> <span \
class="o">*</span> <span class="nx">units</span><span class="p">.</span><span \
class="nx">gridUnit</span><span class="p">)</span> <span class="o">:</span> <span \
class="nb">Math</span><span class="p">.</span><span class="nx">round</span><span \
class="p">(</span><span class="mi">5</span> <span class="o">*</span> <span \
class="nx">units</span><span class="p">.</span><span class="nx">gridUnit</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use a \
>= just for future proofing</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119916/diff/1/?file=307346#file307346line116" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/notifications/plugin/notificationshelper.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
NotificationsHelper::displayNotification(const QVariantMap \
&notificationData)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">115</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">int</span> <span class="n">popupsHeightTotal</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">= \
0;</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">otherwise in non debug builds you're going to get \
garbage</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On August 23rd, 2014, 11:19 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2014, 11:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since the port of the Button component to QQC Button, \
the button height cannot be set anymore, therefore the height of the popup now needs \
to be higher when there are three actions.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/NotificationPopup.qml <span \
style="color: grey">(489fbd1)</span></li>
<li>applets/notifications/plugin/notificationshelper.cpp <span style="color: \
grey">(783c0e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119916/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0252576051341710520==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic