'Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2014-08-12 13:25:34
Message-ID: 20140812132534.14668.62255 () probe ! kde ! org
[Download RAW message or body]

--===============7569114178209311173==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110216/#review64377
-----------------------------------------------------------

It's fixed in Plasma 5, anyway.

- Sebastian Kügler

On Aug. 11, 2014, 7:14 p.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110216/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 7:14 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> 'Screen Locker' sounds wrong, a locker is something you keep your books at school \
> in. 
> 'Lock Screen' is currently frequently used in English on phones and is also used by \
> Gnome Shell for their screensaver replacement. 
> 
> Diffs
> -----
> 
> kcontrol/screensaver/screensaver.desktop d1f887a 
> 
> Diff: https://git.reviewboard.kde.org/r/110216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Will Stephenson
> 
> 

--===============7569114178209311173==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110216/">https://git.reviewboard.kde.org/r/110216/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
fixed in Plasma 5, anyway.</p></pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On August 11th, 2014, 7:14 p.m. UTC, Will Stephenson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Will Stephenson.</div>

<p style="color: grey;"><i>Updated Aug. 11, 2014, 7:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">&#39;Screen Locker&#39; sounds wrong, a locker is something you keep \
your books at school in.

&#39;Lock Screen&#39; is currently frequently used in English on phones and is also \
used by Gnome Shell for their screensaver replacement.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/screensaver/screensaver.desktop <span style="color: \
grey">(d1f887a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/110216/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7569114178209311173==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 