[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-08-11 19:14:04
Message-ID: 20140811191404.14667.90861 () probe ! kde ! org
[Download RAW message or body]
--===============3877508882432104423==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On abr. 27, 2013, 2:09 p.m., Marco Martin wrote:
> > Ship It!
>
> Albert Astals Cid wrote:
> Janitorial dude question: Has this been commited and you forgot to mark it as \
> submitted or it does still need submitting?
>
> Marco Martin wrote:
> should still be committed
>
> Albert Astals Cid wrote:
> Want me to do it? Marco, Will? Note this introduces a string change, so frameworks \
> branch only? Or request a i18n exception for 4.11.x?
No answer in a year, i'll discard it. You two are grown up enough and should get your \
shit up together if you want your stuff to be commited.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110216/#review31682
-----------------------------------------------------------
On abr. 27, 2013, 11:37 a.m., Will Stephenson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110216/
> -----------------------------------------------------------
>
> (Updated abr. 27, 2013, 11:37 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> 'Screen Locker' sounds wrong, a locker is something you keep your books at school \
> in.
> 'Lock Screen' is currently frequently used in English on phones and is also used by \
> Gnome Shell for their screensaver replacement.
>
> Diffs
> -----
>
> kcontrol/screensaver/screensaver.desktop d1f887a
>
> Diff: https://git.reviewboard.kde.org/r/110216/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Will Stephenson
>
>
--===============3877508882432104423==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110216/">https://git.reviewboard.kde.org/r/110216/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On abril 27th, 2013, 2:09 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On agost 15th, 2013, 10:05 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Janitorial dude \
question: Has this been commited and you forgot to mark it as submitted or it does \
still need submitting? </pre>
</blockquote>
<p>On agost 15th, 2013, 10:24 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should still be \
committed</pre> </blockquote>
<p>On agost 15th, 2013, 10:43 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Want me to do it? Marco, \
Will? Note this introduces a string change, so frameworks branch only? Or request a \
i18n exception for 4.11.x?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No \
answer in a year, i'll discard it. You two are grown up enough and should get your \
shit up together if you want your stuff to be commited.</p></pre> <br />
<p>- Albert</p>
<br />
<p>On abril 27th, 2013, 11:37 a.m. UTC, Will Stephenson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Will Stephenson.</div>
<p style="color: grey;"><i>Updated abr. 27, 2013, 11:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">'Screen Locker' sounds wrong, a locker is something you keep \
your books at school in.
'Lock Screen' is currently frequently used in English on phones and is also \
used by Gnome Shell for their screensaver replacement.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/screensaver/screensaver.desktop <span style="color: \
grey">(d1f887a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110216/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3877508882432104423==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic