'Re: Review Request 119664: Plasma-Mobile: Widget Explorer is now able to select the items before we '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119664: Plasma-Mobile: Widget Explorer is now able to select the items before we 
From:       "Antonis Tsiapaliokas" <antonis.tsiapaliokas () kde ! org>
Date:       2014-08-08 14:40:34
Message-ID: 20140808144034.20974.35109 () probe ! kde ! org
[Download RAW message or body]

--===============3475068736443276816==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119664/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 2:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-mobile

Description
-------

This patch adds multiple select support for the Widget Explorer. Until now, if you \
single clicked into to an item, then this item  was being added to the containment \
and the Widget Explorer was closing. That behaviour is not very friendly if you want \
to add  a lot of items.

Diffs
-----

  activeshellpackage/package/contents/explorer/CategoryTab.qml ff9e6dd 
  activeshellpackage/package/contents/explorer/MenuTabBar.qml 55a9c24 
  activeshellpackage/package/contents/explorer/ResourceBrowser.qml da049e0 
  activeshellpackage/package/contents/explorer/WidgetExplorer.qml 5136ee3 
  activeshellpackage/package/contents/explorer/CommonDelegate.qml 4ee4876 

Diff: https://git.reviewboard.kde.org/r/119664/diff/

Testing
-------

File Attachments
----------------

add multiple items
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/b1663a9a-7962-4a3f-bfd1-c2f2ac24ba9a__widgetexplorer_additems.png

Thanks,

Antonis Tsiapaliokas

--===============3475068736443276816==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119664/">https://git.reviewboard.kde.org/r/119664/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Aug. 8, 2014, 2:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds multiple select support for the Widget \
Explorer. Until now, if you single clicked into to an item, then this item <br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> was being added to the containment and the Widget Explorer was closing. \
That behaviour is not very friendly if you want to add <br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> a \
lot of items.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>activeshellpackage/package/contents/explorer/CategoryTab.qml <span style="color: \
grey">(ff9e6dd)</span></li>

 <li>activeshellpackage/package/contents/explorer/MenuTabBar.qml <span style="color: \
grey">(55a9c24)</span></li>

 <li>activeshellpackage/package/contents/explorer/ResourceBrowser.qml <span \
style="color: grey">(da049e0)</span></li>

 <li>activeshellpackage/package/contents/explorer/WidgetExplorer.qml <span \
style="color: grey">(5136ee3)</span></li>

 <li>activeshellpackage/package/contents/explorer/CommonDelegate.qml <span \
style="color: grey">(4ee4876)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119664/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/08/b1663a9a-7962-4a3f-bfd1-c2f2ac24ba9a__widgetexplorer_additems.png">add \
multiple items</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3475068736443276816==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 