[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119618: add theme selection for screen lockers
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-08-06 10:40:24
Message-ID: 20140806104024.20974.18014 () probe ! kde ! org
[Download RAW message or body]
--===============1095187380946988870==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 6, 2014, 9:20 a.m., David Edmundson wrote:
> > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 115
> > <https://git.reviewboard.kde.org/r/119618/diff/2/?file=296899#file296899line115>
> >
> > Either we need to set the language domain or use i18nd
>
> Marco Martin wrote:
> isn't add_definitions(-DTRANSLATION_DOMAIN=\"screenlocker_kcm\") in the cmake \
> enough? or can be only one domain per process?
>
> David Edmundson wrote:
> I don't think so.
> i18n in C++ (in KF5) is a macro that expands to i18nd(TRANSLATION_DOMAIN, whatever)
>
> in QML we're obviously not a macro, so that won't happen, so kdeclarative uses \
> whatever domain it's set to.
> David Edmundson wrote:
> and kdeclrative::rootcontext.cpp starts with
>
> // Undefine this because we don't want our i18n*() method names to be turned into \
> i18nd*() #undef TRANSLATION_DOMAIN
right, kdeclarative is in another library, so TRANSLATION_DOMAIN is obviously \
different when called from there
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119618/#review63902
-----------------------------------------------------------
On Aug. 6, 2014, 10:39 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119618/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 10:39 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> one thing that was requested a lot as well, is an override on the screen locker \
> package as is done in the splash screen as well (master already supports reading it \
> from config, the kcm to set that was missing tough)
>
> Diffs
> -----
>
> ksmserver/screenlocker/kcm/CMakeLists.txt 17e4f70
> ksmserver/screenlocker/kcm/kcm.h PRE-CREATION
> ksmserver/screenlocker/kcm/kcm.cpp d74ab75
> ksmserver/screenlocker/kcm/kcm.ui 1cc2653
> ksmserver/screenlocker/kcm/package/contents/ui/main.qml PRE-CREATION
> ksmserver/screenlocker/kcm/package/metadata.desktop PRE-CREATION
> lookandfeel/contents/lockscreen/screenshot.png PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119618/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> locker.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/1174ed52-d86c-4345-9790-0cb5dd8f75ca__locker.png
>
>
> Thanks,
>
> Marco Martin
>
>
--===============1095187380946988870==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119618/">https://git.reviewboard.kde.org/r/119618/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 6th, 2014, 9:20 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119618/diff/2/?file=296899#file296899line115" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/kcm/package/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">115</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">tooltip:</span> <span class="nx">i18n</span><span \
class="p">(</span><span class="s2">"Test Screen Locker"</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Either we need to set the language domain or use i18nd</p></pre> \
</blockquote>
<p>On August 6th, 2014, 10:02 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">isn't \
add_definitions(-DTRANSLATION_DOMAIN=\"screenlocker_kcm\") in the cmake enough?<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> or can be only one domain per process?</p></pre>
</blockquote>
<p>On August 6th, 2014, 10:26 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think so.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> i18n in C++ (in KF5) is a macro that expands to \
i18nd(TRANSLATION_DOMAIN, whatever)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">in QML we're obviously \
not a macro, so that won't happen, so kdeclarative uses whatever domain it's set \
to.</p></pre> </blockquote>
<p>On August 6th, 2014, 10:32 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
kdeclrative::rootcontext.cpp starts with</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">// Undefine this \
because we don't want our i18n<em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">() method names to be turned into \
i18nd</em>()</p> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">undef \
TRANSLATION_DOMAIN</h1></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">right, kdeclarative is in another library, so TRANSLATION_DOMAIN is \
obviously different when called from there</p></pre> <br />
<p>- Marco</p>
<br />
<p>On August 6th, 2014, 10:39 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2014, 10:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">one thing that was requested a lot as well, is an \
override on the screen locker package as is done in the splash screen as well (master \
already supports reading it from config, the kcm to set that was missing \
tough)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/kcm/CMakeLists.txt <span style="color: \
grey">(17e4f70)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.cpp <span style="color: \
grey">(d74ab75)</span></li>
<li>ksmserver/screenlocker/kcm/kcm.ui <span style="color: \
grey">(1cc2653)</span></li>
<li>ksmserver/screenlocker/kcm/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcm/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeel/contents/lockscreen/screenshot.png <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119618/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/1174ed52-d86c-4345-9790-0cb5dd8f75ca__locker.png">locker.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1095187380946988870==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic