[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component
From: "Antonis Tsiapaliokas" <antonis.tsiapaliokas () kde ! org>
Date: 2014-08-04 11:43:47
Message-ID: 20140804114347.20973.92152 () probe ! kde ! org
[Download RAW message or body]
--===============1658930042733605244==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119552/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 11:43 a.m.)
Review request for Plasma.
Changes
-------
* License from GPL -> LGPL
* The Kio class -> KRunProxy class
Repository: kdeclarative
Description
-------
With the specific component we will be able to open files,documents,applications etc.
Because until now we are not able to open them.
Diffs (updated)
-----
src/qmlcontrols/CMakeLists.txt bab913b
src/qmlcontrols/kioplugin/CMakeLists.txt PRE-CREATION
src/qmlcontrols/kioplugin/kio.h PRE-CREATION
src/qmlcontrols/kioplugin/kio.cpp PRE-CREATION
src/qmlcontrols/kioplugin/kioplugin.h PRE-CREATION
src/qmlcontrols/kioplugin/kioplugin.cpp PRE-CREATION
src/qmlcontrols/kioplugin/qmldir PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119552/diff/
Testing
-------
Everything seems to work ok.
* Applications open properly if we pass their desktop file as a parameter
* Files and images are opening properly
Thanks,
Antonis Tsiapaliokas
--===============1658930042733605244==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119552/">https://git.reviewboard.kde.org/r/119552/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2014, 11:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* License from GPL -> LGPL
* The Kio class -> KRunProxy class</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With the specific component we will be able to open \
files,documents,applications etc.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Because until now we \
are not able to open them.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything seems to work ok.</p> <ul style="padding: \
0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Applications open properly if we pass their desktop \
file as a parameter</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Files and images are opening \
properly</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/CMakeLists.txt <span style="color: grey">(bab913b)</span></li>
<li>src/qmlcontrols/kioplugin/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kio.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kio.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kioplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kioplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119552/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1658930042733605244==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic