[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118539: I needed this patch in order to succesfully compile a 20140603 git snapsh
From:       Eric Hameleers <alien () slackware ! com>
Date:       2014-07-29 12:52:52
Message-ID: alpine.LNX.2.02.1407290550140.29601 () connie ! slackware ! com
[Download RAW message or body]

On Tue, 29 Jul 2014, Bhushan Shah wrote:

> > On June 5, 2014, 1:58 a.m., Marco Martin wrote:
> > > what is the stuff that still needs kdelibs4support? it shouldn't depend on it anymore
> > 
> > Eric Hameleers wrote:
> > Files in the subdirectories of kcms/kfintinst/ contain includes for stuff that I can only \
> > find in kdelibs4support. Like "#include <KGlobal>" in kcms/kfontinst/lib/FcEngine.cpp to \
> > give one example. SInce all it complains about is the includes, perhaps those can be \
> > removed without harm... I don't know and I did not try, I am not a developer but a \
> > packager. 
> > If I don't apply the patch (just tried) the build fails here at first (and if you gradually \
> > apply all the parts of the patch the build will fail in other directories) because of a \
> > missing include: 
> > [ 77%] Automoc for target kfontinst
> > [ 77%] Built target kfontinst_automoc
> > [ 79%] Built target kfontinst
> > [ 79%] Automoc for target kfontinstui
> > [ 79%] Built target kfontinstui_automoc
> > [ 79%] Building CXX object kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o
> > In file included from \
> > /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.h:32:0, \
> > from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.cpp:24:
> >                 
> > /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/KfiConstants.h:28:28: \
> > fatal error: KLocalizedString: No such file or directory #include <KLocalizedString>
> > ^
> > compilation terminated.
> > make[2]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o] Error 1
> > make[1]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/all] Error 2
> > make: *** [all] Error 2
> > plasma:plasma-desktop failed to build.
> > 
> 
> Ping, whats status on this? can this be required?
> 
> 
> - Bhushan

I can not tell, since I stopped compiling Slackware packages for 
Plasma Next for lack of progress on the reviewboard.
Once this is fixed I will try again.

-- 
Eric Hameleers <alien@slackware.com>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]