[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2014-08-03 4:36:34
Message-ID: 20140803043634.17765.94970 () probe ! kde ! org
[Download RAW message or body]
--===============5979911885500499414==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 1, 2014, 5:36 p.m., Sinny Kumari wrote:
> > mediaelements/mediaplayer/MediaPlayer.qml, line 108
> > <https://git.reviewboard.kde.org/r/118406/diff/3/?file=294832#file294832line108>
> >
> > Rather than saying "Please make sure the location is accessible and try again" , \
> > it should be "please make sure media exists". Media inaccesible could be due to \
> > multiple reason like renaming of media, deleting media or unmounting \
> > partition/device which is kind of deletion of media for my computer.
>
> Ashish Madeti wrote:
> Is it guaranteed that the error in video can only arise due to location not \
> accessible (or because the file does not exist)? I have seen the same screen (as \
> mentioned in the bug, https://docs.google.com/file/d/0Bxf5QIFnNjVeRHFCdzFkTVRtRDA) \
> when the necessary codecs are not present. In that case, I guess we need some \
> generic error message.
> Thomas Pfeiffer wrote:
> If files being unplayable due to missing codecs, a different message has to be \
> shown. If we wrote a message generic enough to cover both cases, it would be too \
> generic to be of any value to the user.
> R.Harish Navnit wrote:
> @Ashish, I think the error property of the video element covers most types of \
> errors. I myself have some codecs missing and I'm able to view this message. \
> @Thomas, yes, so I can write specific error messages for specific cases. But do you \
> want this type of interface in the first place ? I want the user to see this page \
> only when he double clicks the media from the playlist. Otherwise, I would like to \
> change the opacity property to notify the user. Would love some help on the \
> implementation part of the same :)
"I myself have some codecs missing and I'm able to view this message."
That is exactly Ashish's point, the error message in this review tells the user that \
the location is inaccessible while in reality she is missing codecs. So basically the \
error message will turn out to be wrong.
So, what we should do is depending on the type of error, show the appropriate error \
message when a media is errored when selected from the media browser. The type of \
error can be read from \
http://doc.qt.digia.com/qtmobility-1.2.0/qml-video.html#error-prop .
Playlist should still continue to skip the media and not show any error and stop.
- Shantanu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review63648
-----------------------------------------------------------
On Aug. 1, 2014, 4:03 p.m., R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 4:03 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Bugs: 333764
> http://bugs.kde.org/show_bug.cgi?id=333764
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> If a media(in a playlist) is located in an inaccessible location, then the user is \
> notified about the same.
>
> Diffs
> -----
>
> mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c
> mediaelements/playlist/Playlist.qml 5dde297
>
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
>
>
> Testing
> -------
>
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
> --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
> -- The media plays properly.
>
>
> File Attachments
> ----------------
>
> wihtout_i18n.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
>
>
> Thanks,
>
> R.Harish Navnit
>
>
--===============5979911885500499414==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118406/">https://git.reviewboard.kde.org/r/118406/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 1st, 2014, 5:36 p.m. UTC, <b>Sinny \
Kumari</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118406/diff/3/?file=294832#file294832line108" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/mediaplayer/MediaPlayer.qml</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">108</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="o">+</span> <span class="s2">"\n\n"</span> <span \
class="o">+</span> <span class="nx">i18n</span><span class="p">(</span><span \
class="s2">"Please make sure the location is accessible and try \
again"</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Rather than saying "Please make sure the location is accessible and try \
again" , it should be "please make sure media exists". Media inaccesible could be due \
to multiple reason like renaming of media, deleting media or unmounting \
partition/device which is kind of deletion of media for my computer.</p></pre> \
</blockquote>
<p>On August 1st, 2014, 5:48 p.m. UTC, <b>Ashish Madeti</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it \
guaranteed that the error in video can only arise due to location not accessible (or \
because the file does not exist)? I have seen the same screen (as mentioned in the \
bug, https://docs.google.com/file/d/0Bxf5QIFnNjVeRHFCdzFkTVRtRDA) when the necessary \
codecs are not present.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> In that case, I guess we need some \
generic error message.</p></pre> </blockquote>
<p>On August 2nd, 2014, 12:55 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
files being unplayable due to missing codecs, a different message has to be shown. If \
we wrote a message generic enough to cover both cases, it would be too generic to be \
of any value to the user.</p></pre> </blockquote>
<p>On August 2nd, 2014, 11:37 a.m. UTC, <b>R.Harish Navnit</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Ashish, I think the error property of the video element covers most types \
of errors. I myself have some codecs missing and I'm able to view this message. <br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> @Thomas, yes, so I can write specific error messages for specific cases. \
But do you want this type of interface in the first place ? I want the user to see \
this page only when he double clicks the media from the playlist. Otherwise, I would \
like to change the opacity property to notify the user. <br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Would love some help on the implementation part of the same :)</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">"I myself have some codecs missing and I'm able to view this message."<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> That is exactly Ashish's point, the error message in this review tells \
the user that the location is inaccessible while in reality she is missing codecs. So \
basically the error message will turn out to be wrong.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, \
what we should do is depending on the type of error, show the appropriate error \
message when a media is errored when selected from the media browser. The type of \
error can be read from \
http://doc.qt.digia.com/qtmobility-1.2.0/qml-video.html#error-prop .</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Playlist should still continue to skip the media and not show any error and \
stop.</p></pre> <br />
<p>- Shantanu</p>
<br />
<p>On August 1st, 2014, 4:03 p.m. UTC, R.Harish Navnit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2014, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333764">333764</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If a media(in a playlist) is located in an \
inaccessible location, then the user is notified about the same. </p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">1. Load media to a playlist.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 2. \
Unmount the device containing media.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> 3. Check if the user \
is notified of the location being inaccessible<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
--yes, the user is notified<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 4. Mount the device containing media \
and play a media from playlist.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
-- The media plays properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: \
grey">(98f1d2c)</span></li>
<li>mediaelements/playlist/Playlist.qml <span style="color: \
grey">(5dde297)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118406/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png">wihtout_i18n.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5979911885500499414==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic