[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2014-08-01 17:36:30
Message-ID: 20140801173630.3288.55260 () probe ! kde ! org
[Download RAW message or body]
--===============1190858401416017206==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review63648
-----------------------------------------------------------
Couple of issues:
1. While I am playing songs from playlist, suppose there are three inaccessible media \
in between. Now, I press next then control will skip 3 inacessible media and will \
play 4th one. Now, if I press previous, it should play last accesible media i.e media \
before 3 inaccesible media but here it keeps playing same. 2. As Thomas suggested, in \
playlist we should Grey out the entry in the playlist for inaccessible media. This \
may be fixed in same review or maybe in a new review request 3. When playing \
inaccessible media from mediabrowser, show only error message in videoplayer, don't \
show music icon. Looks clutter due to that.
mediaelements/mediaplayer/MediaPlayer.qml
<https://git.reviewboard.kde.org/r/118406/#comment44345>
Rather than saying "Please make sure the location is accessible and try again" , \
it should be "please make sure media exists". Media inaccesible could be due to \
multiple reason like renaming of media, deleting media or unmounting partition/device \
which is kind of deletion of media for my computer.
- Sinny Kumari
On Aug. 1, 2014, 4:03 p.m., R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 4:03 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Bugs: 333764
> http://bugs.kde.org/show_bug.cgi?id=333764
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> If a media(in a playlist) is located in an inaccessible location, then the user is \
> notified about the same.
>
> Diffs
> -----
>
> mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c
> mediaelements/playlist/Playlist.qml 5dde297
>
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
>
>
> Testing
> -------
>
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
> --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
> -- The media plays properly.
>
>
> File Attachments
> ----------------
>
> wihtout_i18n.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
>
>
> Thanks,
>
> R.Harish Navnit
>
>
--===============1190858401416017206==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118406/">https://git.reviewboard.kde.org/r/118406/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Couple of issues:<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 1. While I am playing songs from \
playlist, suppose there are three inaccessible media in between. Now, I press next \
then control will skip 3 inacessible media and will play 4th one. Now, if I press \
previous, it should play last accesible media i.e media before 3 inaccesible media \
but here it keeps playing same.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 2. As Thomas suggested, in playlist \
we should Grey out the entry in the playlist for inaccessible media. This may be \
fixed in same review or maybe in a new review request<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 3. \
When playing inaccessible media from mediabrowser, show only error message in \
videoplayer, don't show music icon. Looks clutter due to that.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118406/diff/3/?file=294832#file294832line108" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/mediaplayer/MediaPlayer.qml</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">108</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="o">+</span> <span class="s2">"\n\n"</span> <span \
class="o">+</span> <span class="nx">i18n</span><span class="p">(</span><span \
class="s2">"Please make sure the location is accessible and try \
again"</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Rather than saying "Please make sure the location is accessible and try \
again" , it should be "please make sure media exists". Media inaccesible could be due \
to multiple reason like renaming of media, deleting media or unmounting \
partition/device which is kind of deletion of media for my computer.</p></pre> \
</div> </div>
<br />
<p>- Sinny Kumari</p>
<br />
<p>On August 1st, 2014, 4:03 p.m. UTC, R.Harish Navnit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By R.Harish Navnit.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2014, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333764">333764</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If a media(in a playlist) is located in an \
inaccessible location, then the user is notified about the same. </p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">1. Load media to a playlist.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 2. \
Unmount the device containing media.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> 3. Check if the user \
is notified of the location being inaccessible<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
--yes, the user is notified<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 4. Mount the device containing media \
and play a media from playlist.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
-- The media plays properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediaplayer/MediaPlayer.qml <span style="color: \
grey">(98f1d2c)</span></li>
<li>mediaelements/playlist/Playlist.qml <span style="color: \
grey">(5dde297)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118406/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png">wihtout_i18n.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1190858401416017206==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic