[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119451: some machinery for look and feel package
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-07-31 13:53:03
Message-ID: 20140731135303.3288.3541 () probe ! kde ! org
[Download RAW message or body]
--===============4585036794699771420==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119451/
-----------------------------------------------------------
(Updated July 31, 2014, 1:53 p.m.)
Review request for Plasma.
Changes
-------
screen locker, osd, krunner, logout screen get taken from the lnf package too
adds a simple qml based kcm for the splashscreen.
the kcm has to be there instead of plasma-desktop since it uses lookandfeelaccess (as \
the lookandfeel kcm will have to be here too)
Repository: plasma-workspace
Description
-------
This is still nowhere near final mergeability, but rather a request for comments for \
early stages ;)
So, what does an application that uses stuff from l&f needs?
* open the proper l&f package, as configured
* fetch files from it
* use files of the default one if the provided one is incomplete
* monitor for theme changes and if necessary reload the qml
* some applications may even want to have an optional local config that overrides it, \
like the splash, but is out of scope of a central management
the branch uses a little class that does all of the above (minus the last point) and \
uses it for now in the splash screen For now it would just be statically linked into \
users, since they should be all in plasma-framework for now (of course not optimal)
*maybe* is stuff for libplasmaquick, but that library since locks a release of p-f \
with the same release of users of it, should probably me made public or else, so I'm \
a bit hesitant to add further stuff into it.
Diffs (updated)
-----
CMakeLists.txt c95eee9
kcms/CMakeLists.txt PRE-CREATION
kcms/splash/CMakeLists.txt PRE-CREATION
kcms/splash/Messages.sh PRE-CREATION
kcms/splash/kcm.h PRE-CREATION
kcms/splash/kcm.cpp PRE-CREATION
kcms/splash/kcm_splashscreen.desktop PRE-CREATION
kcms/splash/package/contents/ui/main.qml PRE-CREATION
kcms/splash/package/metadata.desktop PRE-CREATION
krunner/CMakeLists.txt 2eb3671
krunner/view.cpp 21e66b2
ksmserver/CMakeLists.txt 49870fb
ksmserver/screenlocker/greeter/CMakeLists.txt 4837017
ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd
ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 5480022
ksmserver/shutdowndlg.cpp ccf6dd9
ksmserver/tests/CMakeLists.txt 79e942e
ksplash/ksplashqml/CMakeLists.txt 16c58a0
ksplash/ksplashqml/SplashWindow.cpp 23603f5
ksplash/ksplashqml/shellpluginloader.h 9c0f624
lookandfeel/contents/defaults 8b58863
lookandfeel/contents/splash/screenshot.png PRE-CREATION
lookandfeel/metadata.desktop fbb4858
lookandfeelaccess/lookandfeelaccess.h PRE-CREATION
lookandfeelaccess/lookandfeelaccess.cpp PRE-CREATION
lookandfeelaccess/shellpluginloader.h PRE-CREATION
shell/CMakeLists.txt 529e543
shell/osd.cpp 0e1adcc
shell/shellcorona.cpp 1d92cf8
Diff: https://git.reviewboard.kde.org/r/119451/diff/
Testing
-------
File Attachments (updated)
----------------
snapshot3.png
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/2372f956-e086-4345-b89c-aca056b420f9__snapshot3.png
Thanks,
Marco Martin
--===============4585036794699771420==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119451/">https://git.reviewboard.kde.org/r/119451/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 31, 2014, 1:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">screen locker, osd, krunner, logout screen get taken from the lnf \
package too
adds a simple qml based kcm for the splashscreen.
the kcm has to be there instead of plasma-desktop since it uses lookandfeelaccess (as \
the lookandfeel kcm will have to be here too)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is still nowhere near final mergeability, but \
rather a request for comments for early stages ;)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, \
what does an application that uses stuff from l&f needs?<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;"> open the proper l&f package, as configured<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
</em> fetch files from it<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> use files of the \
default one if the provided one is incomplete<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> </em> monitor for \
theme changes and if necessary reload the qml<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
* some applications may even want to have an optional local config that overrides it, \
like the splash, but is out of scope of a central management</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
branch uses a little class that does all of the above (minus the last point) and uses \
it for now in the splash screen<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> For now it would just be statically \
linked into users, since they should be all in plasma-framework for now (of course \
not optimal)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">maybe</em> is stuff for libplasmaquick, \
but that library since locks a release of p-f with the same release of users of it, \
should probably me made public or else, so I'm a bit hesitant to add further stuff \
into it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c95eee9)</span></li>
<li>kcms/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/kcm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/kcm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/splash/kcm_splashscreen.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/splash/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/splash/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>krunner/CMakeLists.txt <span style="color: grey">(2eb3671)</span></li>
<li>krunner/view.cpp <span style="color: grey">(21e66b2)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(49870fb)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(4837017)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(bb8a2bd)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg <span style="color: \
grey">(5480022)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(ccf6dd9)</span></li>
<li>ksmserver/tests/CMakeLists.txt <span style="color: grey">(79e942e)</span></li>
<li>ksplash/ksplashqml/CMakeLists.txt <span style="color: \
grey">(16c58a0)</span></li>
<li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: \
grey">(23603f5)</span></li>
<li>ksplash/ksplashqml/shellpluginloader.h <span style="color: \
grey">(9c0f624)</span></li>
<li>lookandfeel/contents/defaults <span style="color: grey">(8b58863)</span></li>
<li>lookandfeel/contents/splash/screenshot.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeel/metadata.desktop <span style="color: grey">(fbb4858)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeelaccess/shellpluginloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(529e543)</span></li>
<li>shell/osd.cpp <span style="color: grey">(0e1adcc)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(1d92cf8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119451/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/2372f956-e086-4345-b89c-aca056b420f9__snapshot3.png">snapshot3.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4585036794699771420==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic