[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-07-29 16:39:05
Message-ID: 20140729163905.15443.27276 () probe ! kde ! org
[Download RAW message or body]
--===============0197907447798929811==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On July 29, 2014, 4:34 p.m., Bhushan Shah wrote:
> > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44
> > <https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44>
> >
> > Maybe consider creating it a singleton type?
Why? In fact, I think it's usually harder to deal with singletons and less explicit.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/#review63453
-----------------------------------------------------------
On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119535/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 2:31 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Move QML bindings for KUser to kdeclarative
>
> This code has already been released, but privately inside Kickoff. As it is not \
> strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. \
> There are already other bindings for classes from KCoreAddons there, so this seems \
> like a nice fit.
> The class is useful as public API since it allows customization of apps, making the \
> user feel more familiar with the program at hand. I want to use the name and face \
> icon of the user in more places (systemsettings redesign comes to mind), so it'd be \
> useful to have it shared.
>
> Diffs
> -----
>
> src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c
> src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e
> src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION
> src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119535/diff/
>
>
> Testing
> -------
>
> Ported an (unreleased) app using this class to the new location, works as expected, \
> no regressions encountered.
>
> Thanks,
>
> Sebastian Kügler
>
>
--===============0197907447798929811==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119535/">https://git.reviewboard.kde.org/r/119535/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 29th, 2014, 4:34 p.m. UTC, <b>Bhushan \
Shah</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119535/diff/1/?file=294241#file294241line44" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
QObject *formats_singletontype_provider(QQmlEngine *engine, QJSEngine \
*scriptEngine)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qmlRegisterType</span><span class="o"><</span><span \
class="n">KUserProxy</span><span class="o">></span><span class="p">(</span><span \
class="n">uri</span><span class="p">,</span> <span class="mi">1</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span \
class="s">"KUser"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
consider creating it a singleton type?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Why? In fact, I think it's usually harder to deal with singletons and less \
explicit.</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On July 29th, 2014, 2:31 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated July 29, 2014, 2:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Move QML bindings for KUser to kdeclarative</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This code has already been released, but privately inside Kickoff. As it is \
not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. \
There are already other bindings for classes from KCoreAddons there, so this seems \
like a nice fit.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The class is useful as public API since \
it allows customization of apps, making the user feel more familiar with the program \
at hand. I want to use the name and face icon of the user in more places \
(systemsettings redesign comes to mind), so it'd be useful to have it \
shared.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ported an (unreleased) app using this class to the new \
location, works as expected, no regressions encountered.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/kcoreaddons/CMakeLists.txt <span style="color: \
grey">(597cc2c)</span></li>
<li>src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp <span style="color: \
grey">(3c1a96e)</span></li>
<li>src/qmlcontrols/kcoreaddons/kuserproxy.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kcoreaddons/kuserproxy.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119535/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0197907447798929811==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic