[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118539: I needed this patch in order to succesfully compile a 20140603 git snapsh
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2014-07-29 11:26:17
Message-ID: 20140729112617.15443.35762 () probe ! kde ! org
[Download RAW message or body]
--===============5259914829037685862==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 5, 2014, 1:58 a.m., Marco Martin wrote:
> > what is the stuff that still needs kdelibs4support? it shouldn't depend on it \
> > anymore
>
> Eric Hameleers wrote:
> Files in the subdirectories of kcms/kfintinst/ contain includes for stuff that I \
> can only find in kdelibs4support. Like "#include <KGlobal>" in \
> kcms/kfontinst/lib/FcEngine.cpp to give one example. SInce all it complains about \
> is the includes, perhaps those can be removed without harm... I don't know and I \
> did not try, I am not a developer but a packager.
> If I don't apply the patch (just tried) the build fails here at first (and if you \
> gradually apply all the parts of the patch the build will fail in other \
> directories) because of a missing include:
> [ 77%] Automoc for target kfontinst
> [ 77%] Built target kfontinst_automoc
> [ 79%] Built target kfontinst
> [ 79%] Automoc for target kfontinstui
> [ 79%] Built target kfontinstui_automoc
> [ 79%] Building CXX object \
> kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o In file included from \
> /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.h:32:0,
> from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.cpp:24:
>
> /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/KfiConstants.h:28:28: \
> fatal error: KLocalizedString: No such file or directory #include \
> <KLocalizedString> ^
> compilation terminated.
> make[2]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o] Error 1
> make[1]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/all] Error 2
> make: *** [all] Error 2
> plasma:plasma-desktop failed to build.
>
Ping, whats status on this? can this be required?
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118539/#review59240
-----------------------------------------------------------
On June 5, 2014, 1:12 a.m., Eric Hameleers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118539/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 1:12 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> I needed this patch in order to succesfully compile a 20140603 git snapshot of \
> plasma-desktop on top of KDE Frameworks 4.100.0
>
> Diffs
> -----
>
> kcms/kfontinst/apps/CMakeLists.txt d166d8a
> kcms/kfontinst/dbus/CMakeLists.txt 5e203eb
> kcms/kfontinst/kcmfontinst/CMakeLists.txt fe3d2cf
> kcms/kfontinst/kio/CMakeLists.txt 90c6e4d
> kcms/kfontinst/lib/CMakeLists.txt 799707d
> kcms/kfontinst/thumbnail/CMakeLists.txt e19385c
> kcms/kfontinst/viewpart/CMakeLists.txt f79d7a6
>
> Diff: https://git.reviewboard.kde.org/r/118539/diff/
>
>
> Testing
> -------
>
> On Slackware-current x86_64
>
>
> Thanks,
>
> Eric Hameleers
>
>
--===============5259914829037685862==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118539/">https://git.reviewboard.kde.org/r/118539/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 5th, 2014, 1:58 a.m. IST, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">what is the stuff that still needs kdelibs4support? it shouldn't \
depend on it anymore</pre> </blockquote>
<p>On June 5th, 2014, 2:57 a.m. IST, <b>Eric Hameleers</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Files in the \
subdirectories of kcms/kfintinst/ contain includes for stuff that I can only find in \
kdelibs4support. Like "#include <KGlobal>" in \
kcms/kfontinst/lib/FcEngine.cpp to give one example. SInce all it complains about is \
the includes, perhaps those can be removed without harm... I don't know and I did \
not try, I am not a developer but a packager.
If I don't apply the patch (just tried) the build fails here at first (and if you \
gradually apply all the parts of the patch the build will fail in other directories) \
because of a missing include:
[ 77%] Automoc for target kfontinst
[ 77%] Built target kfontinst_automoc
[ 79%] Built target kfontinst
[ 79%] Automoc for target kfontinstui
[ 79%] Built target kfontinstui_automoc
[ 79%] Building CXX object \
kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o In file included from \
/mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.h:32:0,
from \
/mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.cpp:24:
/mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/KfiConstants.h:28:28: \
fatal error: KLocalizedString: No such file or directory #include \
<KLocalizedString> ^
compilation terminated.
make[2]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o] Error 1
make[1]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/all] Error 2
make: *** [all] Error 2
plasma:plasma-desktop failed to build.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping, \
whats status on this? can this be required?</p></pre> <br />
<p>- Bhushan</p>
<br />
<p>On June 5th, 2014, 1:12 a.m. IST, Eric Hameleers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Eric Hameleers.</div>
<p style="color: grey;"><i>Updated June 5, 2014, 1:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I needed this patch in order to succesfully compile a 20140603 git \
snapshot of plasma-desktop on top of KDE Frameworks 4.100.0</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On Slackware-current x86_64</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/kfontinst/apps/CMakeLists.txt <span style="color: \
grey">(d166d8a)</span></li>
<li>kcms/kfontinst/dbus/CMakeLists.txt <span style="color: \
grey">(5e203eb)</span></li>
<li>kcms/kfontinst/kcmfontinst/CMakeLists.txt <span style="color: \
grey">(fe3d2cf)</span></li>
<li>kcms/kfontinst/kio/CMakeLists.txt <span style="color: \
grey">(90c6e4d)</span></li>
<li>kcms/kfontinst/lib/CMakeLists.txt <span style="color: \
grey">(799707d)</span></li>
<li>kcms/kfontinst/thumbnail/CMakeLists.txt <span style="color: \
grey">(e19385c)</span></li>
<li>kcms/kfontinst/viewpart/CMakeLists.txt <span style="color: \
grey">(f79d7a6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118539/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5259914829037685862==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic