[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataen
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-07-29 9:55:36
Message-ID: 20140729095536.15440.30930 () probe ! kde ! org
[Download RAW message or body]

--===============1602069425904380802==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110608/#review63402
-----------------------------------------------------------


submitted with http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=6d5a1ed09f74d117f336517857d7a9a52a72afbf


- David Edmundson


On May 23, 2013, 9:13 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110608/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 9:13 a.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch adds support for keyboard backlight handling to the powermanagement \
> dataengine. 
> It is similar to the backlight handling. Allows setting and getting they keyboard \
> brightness and checking whether it is supported at all. 
> 
> Diffs
> -----
> 
> plasma/generic/dataengines/powermanagement/powermanagementengine.h 319a17c 
> plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 4b184fa 
> plasma/generic/dataengines/powermanagement/powermanagementjob.h 3b974ab 
> plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations \
> 533c00a  
> Diff: https://git.reviewboard.kde.org/r/110608/diff/
> 
> 
> Testing
> -------
> 
> Adjusting keyboard brightness from the battery monitor so coooool.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 


--===============1602069425904380802==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110608/">https://git.reviewboard.kde.org/r/110608/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">submitted with \
http://quickgit.kde.org/?p=kde-workspace.git&amp;a=commit&amp;h=6d5a1ed09f74d117f336517857d7a9a52a72afbf</p></pre>
  <br />









<p>- David Edmundson</p>


<br />
<p>On May 23rd, 2013, 9:13 a.m. UTC, Kai Uwe Broulik wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Solid.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated May 23, 2013, 9:13 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for keyboard backlight handling to the \
powermanagement dataengine.

It is similar to the backlight handling. Allows setting and getting they keyboard \
brightness and checking whether it is supported at all.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adjusting keyboard brightness from the battery monitor so coooool.</pre> \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span \
style="color: grey">(319a17c)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span \
style="color: grey">(4b184fa)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span \
style="color: grey">(3b974ab)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span \
style="color: grey">(6f90006)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementservice.operations \
<span style="color: grey">(533c00a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/110608/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============1602069425904380802==--



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic