'Review Request 119523: port TextField to QtControls'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 119523: port TextField to QtControls
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-07-28 18:10:34
Message-ID: 20140728181034.15443.8543 () probe ! kde ! org
[Download RAW message or body]

--===============7639203676811232843==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.

Repository: plasma-framework

Description
-------

this ports TextField to Qt Controls.

Not sure if is really meargeable tough, because the old one used to export several \
properties and functions more, but they are not possible anymore, because in order \
for them to work is needed the access to the internal TextInput, and we don't have \
that, so some api should have to be dropped, breaking the compatibility promise. \
(another option would be to still use an own implementation, but use a compatible \
style anyways)

Diffs
-----

  src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58 
  src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119523/diff/

Testing
-------

Thanks,

Marco Martin

--===============7639203676811232843==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119523/">https://git.reviewboard.kde.org/r/119523/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this ports TextField to Qt Controls.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not sure if is really meargeable tough, because the old one used to export \
several properties and functions more, but they are not possible anymore, because in \
order for them to work is needed the access to the internal TextInput, and we don't \
have that, so some api should have to be dropped, breaking the compatibility \
promise.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> (another option would be to still use an own \
implementation, but use a compatible style anyways)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: \
grey">(5bc6b58)</span></li>

 <li>src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119523/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7639203676811232843==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 