'Re: Review Request 119522: readlink fails whens the folder does not exist.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119522: readlink fails whens the folder does not exist.
From:       "Rohan Garg" <rohangarg () kubuntu ! org>
Date:       2014-07-28 17:48:54
Message-ID: 20140728174854.15443.95531 () probe ! kde ! org
[Download RAW message or body]

--===============2345467805377989973==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On July 28, 2014, 11:14 p.m., Aleix Pol Gonzalez wrote:
> > So does it still work if it's a link, after this patch?

Yep, works when my ~/.config is a symlink.

- Rohan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119522/#review63351
-----------------------------------------------------------

On July 28, 2014, 10:47 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119522/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 10:47 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/f01badb5aa3f76b27955f4fee2cb7281dd490353 \
> introduced a regression in startkde whereby if ~/.config does not exist readlink \
> will not output the right path. 
> This leads to startkde trying to write to /startupconfigkeys or /kdeglobals which \
> obviously won't work. 
> Since the original commit mentions that relative paths weren't working, I've taken \
> a alternative approach of using ${HOME} instead. 
> 
> Diffs
> -----
> 
> startkde/startkde.cmake 281bd43 
> 
> Diff: https://git.reviewboard.kde.org/r/119522/diff/
> 
> 
> Testing
> -------
> 
> Kubuntu Plasma 5 ISO's did not have the right cursor theme before this patch, after \
> editing startkde by hand, the right files were being correctly written, and the \
> cursor theme worked as expected. 
> 
> Thanks,
> 
> Rohan Garg
> 
> 

--===============2345467805377989973==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119522/">https://git.reviewboard.kde.org/r/119522/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 28th, 2014, 11:14 p.m. IST, <b>Aleix Pol \
Gonzalez</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So does it still work if it's a link, after this \
patch?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yep, \
works when my ~/.config is a symlink.</p></pre> <br />

<p>- Rohan</p>

<br />
<p>On July 28th, 2014, 10:47 p.m. IST, Rohan Garg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Rohan Garg.</div>

<p style="color: grey;"><i>Updated July 28, 2014, 10:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/f01badb5aa3f76b27955f4fee2cb7281dd490353 \
introduced a regression in startkde whereby if ~/.config does not exist readlink will \
not output the right path.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This leads to startkde trying to write \
to /startupconfigkeys or /kdeglobals which obviously won't work.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Since the original commit mentions that relative paths weren't working, \
I've taken a alternative approach of using ${HOME} instead.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Kubuntu Plasma 5 ISO's did not have the right cursor \
theme before this patch, after editing startkde by hand, the right files were being \
correctly written, and the cursor theme worked as expected.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>startkde/startkde.cmake <span style="color: grey">(281bd43)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119522/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2345467805377989973==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 