[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119451: some machinery for look and feel package
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-07-24 10:42:00
Message-ID: 20140724104200.14617.86052 () probe ! kde ! org
[Download RAW message or body]
--===============7830218375833942894==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 24, 2014, 10:34 a.m., David Edmundson wrote:
> > lookandfeelaccess/shellpluginloader.h, line 31
> > <https://git.reviewboard.kde.org/r/119451/diff/1/?file=292285#file292285line31>
> >
> > not used?
that is just the header 1:1 coming from libplasmaquick, usual old problem
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119451/#review63037
-----------------------------------------------------------
On July 24, 2014, 9:43 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119451/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 9:43 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This is still nowhere near final mergeability, but rather a request for comments \
> for early stages ;)
> So, what does an application that uses stuff from l&f needs?
> * open the proper l&f package, as configured
> * fetch files from it
> * use files of the default one if the provided one is incomplete
> * monitor for theme changes and if necessary reload the qml
> * some applications may even want to have an optional local config that overrides \
> it, like the splash, but is out of scope of a central management
> the branch uses a little class that does all of the above (minus the last point) \
> and uses it for now in the splash screen For now it would just be statically linked \
> into users, since they should be all in plasma-framework for now (of course not \
> optimal)
> *maybe* is stuff for libplasmaquick, but that library since locks a release of p-f \
> with the same release of users of it, should probably me made public or else, so \
> I'm a bit hesitant to add further stuff into it.
>
> Diffs
> -----
>
> ksplash/ksplashqml/CMakeLists.txt 16c58a0
> ksplash/ksplashqml/SplashWindow.cpp 23603f5
> ksplash/ksplashqml/shellpluginloader.h 9c0f624
> lookandfeelaccess/lookandfeelaccess.h PRE-CREATION
> lookandfeelaccess/lookandfeelaccess.cpp PRE-CREATION
> lookandfeelaccess/shellpluginloader.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119451/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============7830218375833942894==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119451/">https://git.reviewboard.kde.org/r/119451/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 24th, 2014, 10:34 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119451/diff/1/?file=292285#file292285line31" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lookandfeelaccess/shellpluginloader.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">static</span> <span class="kt">void</span> <span \
class="nf">init</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">not \
used?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">that is just the header 1:1 coming from libplasmaquick, usual old \
problem</p></pre> <br />
<p>- Marco</p>
<br />
<p>On July 24th, 2014, 9:43 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 24, 2014, 9:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is still nowhere near final mergeability, but \
rather a request for comments for early stages ;)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, \
what does an application that uses stuff from l&f needs?<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;"> open the proper l&f package, as configured<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
</em> fetch files from it<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> use files of the \
default one if the provided one is incomplete<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> </em> monitor for \
theme changes and if necessary reload the qml<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
* some applications may even want to have an optional local config that overrides it, \
like the splash, but is out of scope of a central management</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
branch uses a little class that does all of the above (minus the last point) and uses \
it for now in the splash screen<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> For now it would just be statically \
linked into users, since they should be all in plasma-framework for now (of course \
not optimal)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">maybe</em> is stuff for libplasmaquick, \
but that library since locks a release of p-f with the same release of users of it, \
should probably me made public or else, so I'm a bit hesitant to add further stuff \
into it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksplash/ksplashqml/CMakeLists.txt <span style="color: \
grey">(16c58a0)</span></li>
<li>ksplash/ksplashqml/SplashWindow.cpp <span style="color: \
grey">(23603f5)</span></li>
<li>ksplash/ksplashqml/shellpluginloader.h <span style="color: \
grey">(9c0f624)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeelaccess/shellpluginloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119451/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7830218375833942894==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic