[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2014-07-18 21:17:37
Message-ID: 20140718211737.32550.61969 () probe ! kde ! org
[Download RAW message or body]
--===============1251812625634037803==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119025/#review62669
-----------------------------------------------------------
cmake/FindIBus.cmake
<https://git.reviewboard.kde.org/r/119025/#comment43439>
Typo: paramaters
(As a general note, for build system related stuff like this you can also try \
including the "buildsystem" group, which can be more responsive at times)
> The ibus-panel can't build on OpenBSD because some required definitions obtained \
> from pkgconfig file are not used. 1. IBUS_DEFINITIONS is not used in \
> ibus-panel/CMakeLists.txt
Can you post the error you get here? I've tried building kimtoy here on FreeBSD \
expecting to hit the same issue(s), but it all went along just fine.
> 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time
This doesn't make much sense; all values found at configuration time in CMake are \
then used to generate your make/ninja/whatever files, regardless of whether they are \
cached or not.
- Raphael Kubo da Costa
On July 12, 2014, 4:12 p.m., Vadim Zhukov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119025/
> -----------------------------------------------------------
>
> (Updated July 12, 2014, 4:12 p.m.)
>
>
> Review request for kde-workspace, Plasma and Hui Ni.
>
>
> Repository: kimtoy
>
>
> Description
> -------
>
> The ibus-panel can't build on OpenBSD because some required definitions obtained \
> from pkgconfig file are not used. This happens due to the following reasons:
> 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt
> 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time
>
> This patch resolves both issues and makes ibus-panel compile on OpenBSD.
>
> (I found no suitable review group and therefore used "plasma" instead, as it was in \
> "plasma-addons" previously; please, feel free to correct me if I'm wrong and sorry \
> for any possible inconvenience)
> ((as there was no feedback for more than a week, I've added "kde-workspace" group \
> to list of reviewers, too))
>
> Diffs
> -----
>
> cmake/FindIBus.cmake 8250c49
> ibus-panel/CMakeLists.txt 3a1ee49
>
> Diff: https://git.reviewboard.kde.org/r/119025/diff/
>
>
> Testing
> -------
>
> OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the \
> code is same)
>
> Thanks,
>
> Vadim Zhukov
>
>
--===============1251812625634037803==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119025/">https://git.reviewboard.kde.org/r/119025/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119025/diff/1/?file=285402#file285402line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/FindIBus.cmake</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">41</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">set</span><span class="p">(</span><span class="s">IBUS_DEFINITIONS</span> \
<span class="o">${</span><span class="nv">PC_IBUS_CFLAGS_OTHER</span><span \
class="o">}</span><span class="p">)</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">41</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">set</span><span class="p">(</span><span class="s">IBUS_DEFINITIONS</span> \
<span class="s2"><span class="hl">"</span>${PC_IBUS_CFLAGS_OTHER}<span \
class="hl">"</span></span><span class="hl"> </span><span class="s"><span \
class="hl">CACHE</span></span><span class="hl"> </span><span class="s"><span \
class="hl">INTERNAL</span></span><span class="hl"> </span><span class="s2"><span \
class="hl">"Additional paramaters for linking with IBus"</span></span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Typo: \
paramaters</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(As a \
general note, for build system related stuff like this you can also try including the \
"buildsystem" group, which can be more responsive at times)</p> <blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The ibus-panel can't build on OpenBSD because some required definitions \
obtained from pkgconfig file are not used.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> 1. IBUS_DEFINITIONS \
is not used in ibus-panel/CMakeLists.txt</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you post the error you get here? I've tried \
building kimtoy here on FreeBSD expecting to hit the same issue(s), but it all went \
along just fine.</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">IBUS_DEFINITIONS is not \
saved in cache, and thus isn't available at compile time</li> </ol>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This doesn't make much sense; all values found at \
configuration time in CMake are then used to generate your make/ninja/whatever files, \
regardless of whether they are cached or not.</p></pre>
<p>- Raphael Kubo da Costa</p>
<br />
<p>On July 12th, 2014, 4:12 p.m. EEST, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Hui Ni.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated July 12, 2014, 4:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimtoy
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The ibus-panel can't build on OpenBSD because some \
required definitions obtained from pkgconfig file are not used. This happens due to \
the following reasons:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">1. IBUS_DEFINITIONS is not used in \
ibus-panel/CMakeLists.txt<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 2. IBUS_DEFINITIONS is not saved in \
cache, and thus isn't available at compile time</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch resolves both issues and makes ibus-panel compile on OpenBSD.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(I found no suitable review group and therefore used "plasma" instead, as \
it was in "plasma-addons" previously; please, feel free to correct me if I'm wrong \
and sorry for any possible inconvenience)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">((as there was no \
feedback for more than a week, I've added "kde-workspace" group to list of reviewers, \
too))</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy \
package, of course, but the code is same)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindIBus.cmake <span style="color: grey">(8250c49)</span></li>
<li>ibus-panel/CMakeLists.txt <span style="color: grey">(3a1ee49)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119025/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1251812625634037803==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic