[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118388: rename systemsettings binary to systemsettings5
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2014-07-17 4:42:07
Message-ID: 20140717044207.32550.72366 () probe ! kde ! org
[Download RAW message or body]
--===============8397329247305050180==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On May 29, 2014, 7:10 a.m., Ben Cooksley wrote:
> > Code wise, this change looks fine. In terms of renaming the desktop files - i'm \
> > fine with changing the filenames, but please don't change the name of the \
> > application itself. Ideally the KF5 based system settings will still be able to \
> > set configuration details relevant for KDE 4 applications.
>
> Hrvoje Senjan wrote:
> > Ideally the KF5 based system settings will still be able to set configuration \
> > details relevant for KDE 4 applications.
>
> that sounds great to me - just that it would need work in every kcm module. \
> additional caveats: what if there's only 4.x variant of the kcm?
> an option is removed in KF5 variant?
> most importantly - how to implement it (different config locations, etc)? =)
>
> Ben Cooksley wrote:
> Indeed, that could complicate things quite a bit. I'm not sure what we should do in \
> that case then - but we can't have two "System Settings" applications installed \
> which do different things on the same system....
> Martin Gräßlin wrote:
> it's kind of the same situation as we had during the KDE3 -> 4 transition. We had \
> kcontrol to configure KDE3 and systemsettings to configure KDE4.
> The big problem for the developers is that we don't have any access to the KDE4 \
> configuration files, thus it's difficult to adjust the configuration. Now to make \
> it even more complex: should adjusting e.g. the widget style in a Plasma Next \
> session really change the widget style of a Plasma 4 session or just in Plasma \
> Next?
> Ben Cooksley wrote:
> I'm guessing that KDE4 applications probably won't be able to make full use of \
> Plasma Next themes, assuming they keep full compatibility (elements over time may \
> get new names, change format, etc).
> The problem in this case is that the applications have the same name. Should we \
> come up with a new name for the Plasma Next series, or does a mechanism exist to \
> only show particular *.desktop files under Plasma Next / KDE4?
> In any case, the changes to rename the binary and the filenames of the *.desktop \
> files themselves can go ahead - they're independent of this discussion.
> Hrvoje Senjan wrote:
> > In any case, the changes to rename the binary and the filenames of the *.desktop \
> > files themselves can go ahead - they're independent of this >discussion.
> so it's a ship it, as is now? ;-)
>
> Ben Cooksley wrote:
> Yes, it is.
>
> Hrvoje Senjan wrote:
> are we too late for Plasma/5.0 branch? i guess so...
As this improves co-installability, and System Settings is often referenced for user \
support i'd appreciate being able to have both KDE 4 and Plasma 5 based System \
Settings installable if possible. I've no objections to this going into the \
Plasma/5.0 branch - unless release-team / distributions do...
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review58690
-----------------------------------------------------------
On May 28, 2014, 7:32 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118388/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 7:32 p.m.)
>
>
> Review request for Plasma and Ben Cooksley.
>
>
> Repository: systemsettings
>
>
> Description
> -------
>
> while workspace might not be targeted to co-exist with 4.x variant - systemsettings \
> should IMHO be able to co-exist. not only workspace components are adjusting in \
> there, and telling people to do kcmshell$notinstalledvariant $wantedkcm is very \
> user-unfriendly... one TODO if this gets a green light, is to rename desktop files, \
> so people know which variant they are opening.
>
> Diffs
> -----
>
> app/systemsettings.desktop 5f27318
> app/kdesystemsettings.desktop 946d498
> app/CMakeLists.txt c45f7e7
>
> Diff: https://git.reviewboard.kde.org/r/118388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============8397329247305050180==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118388/">https://git.reviewboard.kde.org/r/118388/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 29th, 2014, 7:10 a.m. UTC, <b>Ben \
Cooksley</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code wise, this change looks fine. In terms of renaming the desktop \
files - i'm fine with changing the filenames, but please don't change the \
name of the application itself. Ideally the KF5 based system settings will still be \
able to set configuration details relevant for KDE 4 applications.</pre> \
</blockquote>
<p>On May 29th, 2014, 4:25 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>Ideally the KF5 \
based system settings will still be able to set configuration details relevant for \
KDE 4 applications.
that sounds great to me - just that it would need work in every kcm module. \
additional caveats: what if there's only 4.x variant of the kcm?
an option is removed in KF5 variant?
most importantly - how to implement it (different config locations, etc)? =) </pre>
</blockquote>
<p>On June 3rd, 2014, 5:59 a.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed, that could \
complicate things quite a bit. I'm not sure what we should do in that case then - \
but we can't have two "System Settings" applications installed which do \
different things on the same system....</pre> </blockquote>
<p>On June 3rd, 2014, 6:05 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it's kind of the \
same situation as we had during the KDE3 -> 4 transition. We had kcontrol to \
configure KDE3 and systemsettings to configure KDE4.
The big problem for the developers is that we don't have any access to the KDE4 \
configuration files, thus it's difficult to adjust the configuration. Now to make \
it even more complex: should adjusting e.g. the widget style in a Plasma Next session \
really change the widget style of a Plasma 4 session or just in Plasma Next?</pre> \
</blockquote>
<p>On June 3rd, 2014, 8:50 a.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm guessing that \
KDE4 applications probably won't be able to make full use of Plasma Next themes, \
assuming they keep full compatibility (elements over time may get new names, change \
format, etc).
The problem in this case is that the applications have the same name. Should we come \
up with a new name for the Plasma Next series, or does a mechanism exist to only show \
particular *.desktop files under Plasma Next / KDE4?
In any case, the changes to rename the binary and the filenames of the *.desktop \
files themselves can go ahead - they're independent of this discussion.</pre> \
</blockquote>
<p>On June 8th, 2014, 7:06 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>In any case, the \
changes to rename the binary and the filenames of the *.desktop files themselves can \
go ahead - they're independent of this >discussion. so it's a ship it, as \
is now? ;-)</pre> </blockquote>
<p>On July 16th, 2014, 12:29 p.m. UTC, <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
it is.</p></pre> </blockquote>
<p>On July 16th, 2014, 7:33 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">are \
we too late for Plasma/5.0 branch? i guess so...</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
this improves co-installability, and System Settings is often referenced for user \
support i'd appreciate being able to have both KDE 4 and Plasma 5 based System \
Settings installable if possible. I've no objections to this going into the \
Plasma/5.0 branch - unless release-team / distributions do...</p></pre> <br />
<p>- Ben</p>
<br />
<p>On May 28th, 2014, 7:32 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Ben Cooksley.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 7:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
systemsettings
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">while workspace might not be targeted to co-exist with 4.x variant - \
systemsettings should IMHO be able to co-exist. not only workspace components are \
adjusting in there, and telling people to do kcmshell$notinstalledvariant $wantedkcm \
is very user-unfriendly... one TODO if this gets a green light, is to rename desktop \
files, so people know which variant they are opening.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/systemsettings.desktop <span style="color: grey">(5f27318)</span></li>
<li>app/kdesystemsettings.desktop <span style="color: grey">(946d498)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(c45f7e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118388/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8397329247305050180==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic