[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119315: add an X-KDE-PluginInfo-Version to the plasma.desktop xsession desktop fi
From: "Harald Sitter" <sitter () kde ! org>
Date: 2014-07-16 12:50:05
Message-ID: 20140716125005.32551.6453 () probe ! kde ! org
[Download RAW message or body]
--===============8531110258661939740==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119315/
-----------------------------------------------------------
(Updated July 16, 2014, 12:50 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
this enables applications (such as the about-distro kcm) to list the
version of plasma the user is running at runtime in a somewhat reliable
manner, short of having a library function.
Diffs
-----
plasma.desktop.cmake f0b203e77d215f5afa04a6794e8ab69993ab4987
Diff: https://git.reviewboard.kde.org/r/119315/diff/
Testing
-------
read version... example code for reading:
const QStringList &filePaths = \
QStandardPaths::locateAll(QStandardPaths::GenericDataLocation,
\
"xsessions/plasma.desktop");
if (filePaths.length() < 1) {
return QString();
}
// Despite the fact that there can be multiple desktop files we simply take
// the first one as users usually don't have xsessions/ in their $HOME
// data location, so the first match should (usually) be the only one and
// reflect the plasma session run.
KDesktopFile desktopFile(filePaths.first());
return desktopFile.desktopGroup().readEntry("X-KDE-PluginInfo-Version", \
QString());
Thanks,
Harald Sitter
--===============8531110258661939740==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119315/">https://git.reviewboard.kde.org/r/119315/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated July 16, 2014, 12:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: \
bold">this</span> enables applications (such as the about<span style="color: \
#666666">-</span>distro kcm) to list the version of plasma the user is running at \
runtime <span style="color: #008000; font-weight: bold">in</span> a somewhat reliable \
manner, <span style="color: #008000; font-weight: bold">short</span> of having a \
library <span style="color: #008000; font-weight: bold">function</span>. </pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">read version... example code for reading:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%"><span style="color: #008000; font-weight: \
bold">const</span> QStringList <span style="color: #666666">&</span>filePaths \
<span style="color: #666666">=</span> QStandardPaths<span style="color: \
#666666">::</span>locateAll(QStandardPaths<span style="color: \
#666666">::</span>GenericDataLocation,
<span style="color: \
#BA2121">"xsessions/plasma.desktop"</span>);
<span style="color: #008000; font-weight: bold">if</span> (filePaths.length() <span \
style="color: #666666"><</span> <span style="color: #666666">1</span>) { <span \
style="color: #008000; font-weight: bold">return</span> QString(); }
<span style="color: #408080; font-style: italic">// Despite the fact that there can \
be multiple desktop files we simply take</span> <span style="color: #408080; \
font-style: italic">// the first one as users usually don't have xsessions/ in \
their $HOME</span> <span style="color: #408080; font-style: italic">// data location, \
so the first match should (usually) be the only one and</span> <span style="color: \
#408080; font-style: italic">// reflect the plasma session run.</span> KDesktopFile \
desktopFile(filePaths.first()); <span style="color: #008000; font-weight: \
bold">return</span> desktopFile.desktopGroup().readEntry(<span style="color: \
#BA2121">"X-KDE-PluginInfo-Version"</span>, QString()); </pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma.desktop.cmake <span style="color: \
grey">(f0b203e77d215f5afa04a6794e8ab69993ab4987)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119315/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8531110258661939740==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic