[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119279: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'
From: "Elias Probst" <mail () eliasprobst ! eu>
Date: 2014-07-14 21:31:07
Message-ID: 20140714213107.3846.36769 () probe ! kde ! org
[Download RAW message or body]
--===============0289344757364299434==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119279/
-----------------------------------------------------------
(Updated July 14, 2014, 9:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for Documentation and Plasma.
Repository: khelpcenter
Description
-------
The kxmlgui file for khelpcenter is installed into a deprecated location.
This patch fixes this and the deprecation notice on khelpcenter startup isn't shown \
anymore (*KXMLGUI file found at deprecated location \
("/usr/share/khelpcenter/khelpcenterui.rc") -- please use ${KXMLGUI_INSTALL_DIR} to \
install this file instead.*)
Diffs
-----
CMakeLists.txt dea527d757c01ae92bb34c60d6f59f5af2cd8a7d
Diff: https://git.reviewboard.kde.org/r/119279/diff/
Testing
-------
khelpcenter works.
No deprecation notice shown anymore.
Thanks,
Elias Probst
--===============0289344757364299434==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119279/">https://git.reviewboard.kde.org/r/119279/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Documentation and Plasma.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated July 14, 2014, 9:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khelpcenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The kxmlgui file for khelpcenter is installed into a \
deprecated location.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> This patch fixes this and the \
deprecation notice on khelpcenter startup isn't shown anymore (<em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">KXMLGUI file found at deprecated location \
("/usr/share/khelpcenter/khelpcenterui.rc") -- please use ${KXMLGUI_INSTALL_DIR} to \
install this file instead.</em>)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">khelpcenter works.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> No \
deprecation notice shown anymore.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(dea527d757c01ae92bb34c60d6f59f5af2cd8a7d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119279/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0289344757364299434==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic