'Re: Review Request 119116: KRunner: Show a "Configure" button on the side'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119116: KRunner: Show a "Configure" button on the side
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-04 23:17:26
Message-ID: 20140704231726.4849.69413 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119116/#review61628
-----------------------------------------------------------

This review has been submitted with commit 947867cdb77c99cdccff38c37a254e28a9308d36 \
by Vishesh Handa to branch master.

- Commit Hook

On July 4, 2014, 4:11 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119116/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 4:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Just like what krunner4 had
> 
> 
> Diffs
> -----
> 
> krunner/view.h 86788f8 
> krunner/view.cpp 488b342 
> lookandfeel/contents/runcommand/RunCommand.qml 870ba86 
> 
> Diff: https://git.reviewboard.kde.org/r/119116/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> krunner_withconfig.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png
>  
> 
> Thanks,
> 
> Vishesh Handa
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119116/">https://git.reviewboard.kde.org/r/119116/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 947867cdb77c99cdccff38c37a254e28a9308d36 by Vishesh Handa to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 4th, 2014, 4:11 p.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated July 4, 2014, 4:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Just like what krunner4 had </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krunner/view.h <span style="color: grey">(86788f8)</span></li>

 <li>krunner/view.cpp <span style="color: grey">(488b342)</span></li>

 <li>lookandfeel/contents/runcommand/RunCommand.qml <span style="color: \
grey">(870ba86)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119116/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211 \
-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png">krunner_withconfig.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 