'Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-03 2:02:16
Message-ID: 20140703020216.32416.33039 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119015/#review61518
-----------------------------------------------------------

This review has been submitted with commit a615f2abaef7769f9d287022462e84930821b8f0 \
by Sujith Haridasan to branch master.

- Commit Hook

On June 29, 2014, 3:53 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119015/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 3:53 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> This patch fixes the full screen settings of plasma-mediacenter during exit. Though \
> its bit hackish which I had done. I would like to make this done better. With this \
> change the pmc will save the fullscreen settings before exit. 
> 
> Diffs
> -----
> 
> browsingbackends/utility/exit/CMakeLists.txt 48d12a7 
> browsingbackends/utility/exit/exitbackend.cpp 9fe6cad 
> shells/newshell/mainwindow.cpp 97655d8 
> 
> Diff: https://git.reviewboard.kde.org/r/119015/diff/
> 
> 
> Testing
> -------
> 
> Done testing with fullscreen enabled and exit && fullscreen disabled and exit. Both \
> results were as expected. 
> 
> Thanks,
> 
> Sujith Haridasan
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119015/">https://git.reviewboard.kde.org/r/119015/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a615f2abaef7769f9d287022462e84930821b8f0 by Sujith Haridasan to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On June 29th, 2014, 3:53 p.m. UTC, Sujith Haridasan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Sujith Haridasan.</div>

<p style="color: grey;"><i>Updated June 29, 2014, 3:53 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes the full screen settings of plasma-mediacenter during \
exit. Though its bit hackish which I had done. I would like to make this done better. \
With this change the pmc will save the fullscreen settings before exit.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done testing with fullscreen enabled and exit &amp;&amp; fullscreen \
disabled and exit. Both results were as expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>browsingbackends/utility/exit/CMakeLists.txt <span style="color: \
grey">(48d12a7)</span></li>

 <li>browsingbackends/utility/exit/exitbackend.cpp <span style="color: \
grey">(9fe6cad)</span></li>

 <li>shells/newshell/mainwindow.cpp <span style="color: grey">(97655d8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119015/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 