[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 119081: Install all kioslaves to $libdir/plugins/kf5/kio
From: "Alexander Richardson" <arichardson.kde () gmail ! com>
Date: 2014-07-02 0:18:29
Message-ID: 20140702001829.22336.40998 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119081/
-----------------------------------------------------------
Review request for Plasma.
Repository: kio-extras
Description
-------
This is what the core ioslaves such as file or http do. Also dropped
the kio_ prefix to the library name since it isn't needed now that we
install them into a kio directory
Diffs
-----
archive/CMakeLists.txt ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708
archive/ar.protocol 7a848e505e5f00121e8ec5493564dfacdd405c31
archive/tar.protocol 19447a5e75b106e7a8c8e8396375bb1fc600a6da
archive/zip.protocol ce7c54b4e92dfab29150246bf6588d1f8bb49057
bookmarks/CMakeLists.txt 703b109c2e049edecce1742482bd82e5c92caecd
bookmarks/bookmarks.protocol 0642bd2f7277be8707351582f219281d45834fa6
desktop/CMakeLists.txt f7bd6709340a5f4e7e5f6fbd076400a76b526cd8
desktop/desktop.protocol 0e388386f1794dd90d445ec146ef54a04f595c8b
filter/CMakeLists.txt 240cc7b57bd38e86fd50084e53c17f1672b2b946
filter/bzip.protocol 7d3cb570fbc534fbba22dd8e10472b47053c7195
filter/bzip2.protocol 1baaf7dd610f39325b2aa21bdee5bf1e63e5835f
filter/gzip.protocol 8ed55ec16f49f42fe6d419327484b33d59ec537b
filter/lzma.protocol 13bb28e3d870f8130d052efd97a5a688d9133c31
filter/xz.protocol f4fb7f01146cbf4d5afce528462e0c5dafa9591e
fish/CMakeLists.txt 24136d4dac01a8a08db8d17380661a9051fa0b04
fish/fish.protocol ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2
info/CMakeLists.txt 0163e82c4f865e3fb3b09bf5ddd44e272ce9c609
info/info.protocol fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb
man/CMakeLists.txt 3343ed85978dbbfa72a5f2cc8530d0f0c043df48
man/man.protocol cc100ce5ec48b40c890abe5d7afdf02ef589810b
network/ioslave/CMakeLists.txt 67fc482cd390f35fb2d5c1740994d2fe9db254f1
network/ioslave/network.protocol 1e10cc6c3a6aadf2ee6794ab36200ef6793e324e
nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5
nfs/nfs.protocol 85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001
recentdocuments/CMakeLists.txt bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f
recentdocuments/recentdocuments.protocol c0bf1ebd80a2c696cad3062ef047ac4847270fc5
settings/CMakeLists.txt 5a57a1840fb33b32701a6ecfff24c42739b05c45
settings/settings.protocol efb03e865594f30be5ed0d1013d31a0200eed816
sftp/CMakeLists.txt defb7dd041ebfd5af0ac19a252cc9f2f454f67f9
sftp/sftp.protocol ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8
smb/CMakeLists.txt a3a772f3028995b811b01fcebe11d8715d3e1620
smb/smb.protocol e58597844ff8554e837f6ee8807d17820e377945
thumbnail/CMakeLists.txt f3733d452eb133d2b5a1445740db0312cd5d8251
thumbnail/thumbnail.protocol eef743ab5310007093e6a1c1ff6d8c258f1be5d9
trash/CMakeLists.txt 4ee03581f5d632282efb9b8902b3abb0e95d169c
trash/trash.protocol 277698579c8a70bac5cadff5cc1f379053e4c61e
Diff: https://git.reviewboard.kde.org/r/119081/diff/
Testing
-------
Thanks,
Alexander Richardson
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119081/">https://git.reviewboard.kde.org/r/119081/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alexander Richardson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is what the core ioslaves such as file or http do. Also dropped the \
kio_ prefix to the library name since it isn't needed now that we install them \
into a kio directory</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>archive/CMakeLists.txt <span style="color: \
grey">(ec2cf7ad6c9c645e62a47c94ec617f8a37c5f708)</span></li>
<li>archive/ar.protocol <span style="color: \
grey">(7a848e505e5f00121e8ec5493564dfacdd405c31)</span></li>
<li>archive/tar.protocol <span style="color: \
grey">(19447a5e75b106e7a8c8e8396375bb1fc600a6da)</span></li>
<li>archive/zip.protocol <span style="color: \
grey">(ce7c54b4e92dfab29150246bf6588d1f8bb49057)</span></li>
<li>bookmarks/CMakeLists.txt <span style="color: \
grey">(703b109c2e049edecce1742482bd82e5c92caecd)</span></li>
<li>bookmarks/bookmarks.protocol <span style="color: \
grey">(0642bd2f7277be8707351582f219281d45834fa6)</span></li>
<li>desktop/CMakeLists.txt <span style="color: \
grey">(f7bd6709340a5f4e7e5f6fbd076400a76b526cd8)</span></li>
<li>desktop/desktop.protocol <span style="color: \
grey">(0e388386f1794dd90d445ec146ef54a04f595c8b)</span></li>
<li>filter/CMakeLists.txt <span style="color: \
grey">(240cc7b57bd38e86fd50084e53c17f1672b2b946)</span></li>
<li>filter/bzip.protocol <span style="color: \
grey">(7d3cb570fbc534fbba22dd8e10472b47053c7195)</span></li>
<li>filter/bzip2.protocol <span style="color: \
grey">(1baaf7dd610f39325b2aa21bdee5bf1e63e5835f)</span></li>
<li>filter/gzip.protocol <span style="color: \
grey">(8ed55ec16f49f42fe6d419327484b33d59ec537b)</span></li>
<li>filter/lzma.protocol <span style="color: \
grey">(13bb28e3d870f8130d052efd97a5a688d9133c31)</span></li>
<li>filter/xz.protocol <span style="color: \
grey">(f4fb7f01146cbf4d5afce528462e0c5dafa9591e)</span></li>
<li>fish/CMakeLists.txt <span style="color: \
grey">(24136d4dac01a8a08db8d17380661a9051fa0b04)</span></li>
<li>fish/fish.protocol <span style="color: \
grey">(ff5784eea877d0fd9a3c6ac4724056ddfd8fe5f2)</span></li>
<li>info/CMakeLists.txt <span style="color: \
grey">(0163e82c4f865e3fb3b09bf5ddd44e272ce9c609)</span></li>
<li>info/info.protocol <span style="color: \
grey">(fa8cbb4f6eaaeeaf8bfdead0fad598df8fe588eb)</span></li>
<li>man/CMakeLists.txt <span style="color: \
grey">(3343ed85978dbbfa72a5f2cc8530d0f0c043df48)</span></li>
<li>man/man.protocol <span style="color: \
grey">(cc100ce5ec48b40c890abe5d7afdf02ef589810b)</span></li>
<li>network/ioslave/CMakeLists.txt <span style="color: \
grey">(67fc482cd390f35fb2d5c1740994d2fe9db254f1)</span></li>
<li>network/ioslave/network.protocol <span style="color: \
grey">(1e10cc6c3a6aadf2ee6794ab36200ef6793e324e)</span></li>
<li>nfs/CMakeLists.txt <span style="color: \
grey">(dfc6eae3fad51eee0e736970da9520959eeed1f5)</span></li>
<li>nfs/nfs.protocol <span style="color: \
grey">(85cf2035e44bf7bfe65d4e2b62d1f44fa05d6001)</span></li>
<li>recentdocuments/CMakeLists.txt <span style="color: \
grey">(bc2b9dbf35428cf0dd1e6ad5c6e569806c92d47f)</span></li>
<li>recentdocuments/recentdocuments.protocol <span style="color: \
grey">(c0bf1ebd80a2c696cad3062ef047ac4847270fc5)</span></li>
<li>settings/CMakeLists.txt <span style="color: \
grey">(5a57a1840fb33b32701a6ecfff24c42739b05c45)</span></li>
<li>settings/settings.protocol <span style="color: \
grey">(efb03e865594f30be5ed0d1013d31a0200eed816)</span></li>
<li>sftp/CMakeLists.txt <span style="color: \
grey">(defb7dd041ebfd5af0ac19a252cc9f2f454f67f9)</span></li>
<li>sftp/sftp.protocol <span style="color: \
grey">(ec15eeb26b3ce2efded173f4c7a4cd737e0a05f8)</span></li>
<li>smb/CMakeLists.txt <span style="color: \
grey">(a3a772f3028995b811b01fcebe11d8715d3e1620)</span></li>
<li>smb/smb.protocol <span style="color: \
grey">(e58597844ff8554e837f6ee8807d17820e377945)</span></li>
<li>thumbnail/CMakeLists.txt <span style="color: \
grey">(f3733d452eb133d2b5a1445740db0312cd5d8251)</span></li>
<li>thumbnail/thumbnail.protocol <span style="color: \
grey">(eef743ab5310007093e6a1c1ff6d8c258f1be5d9)</span></li>
<li>trash/CMakeLists.txt <span style="color: \
grey">(4ee03581f5d632282efb9b8902b3abb0e95d169c)</span></li>
<li>trash/trash.protocol <span style="color: \
grey">(277698579c8a70bac5cadff5cc1f379053e4c61e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119081/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic