[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119027: Add basic application to load mediacenter shell
From: "Commit Hook" <null () kde ! org>
Date: 2014-06-30 10:27:16
Message-ID: 20140630102716.19305.65500 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119027/#review61267
-----------------------------------------------------------
This review has been submitted with commit b5be331bd2fc95aac54b7abcfba0c8de0c1ed1df \
by Bhushan Shah to branch frameworks.
- Commit Hook
On June 30, 2014, 9:52 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119027/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 9:52 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Add a basic application to load mediacenter shell,
>
> Which loads shell package
> Creates PlasmaQuick view to load Desktop.qml
> And adds one containment in corona
>
>
> Diffs
> -----
>
> CMakeLists.txt f79e878
> shells/CMakeLists.txt 9877ee3
> shells/application/CMakeLists.txt PRE-CREATION
> shells/application/main.cpp PRE-CREATION
> shells/application/plasmaquick/view.h PRE-CREATION
> shells/application/pmccorona.h PRE-CREATION
> shells/application/pmccorona.cpp PRE-CREATION
> shells/application/pmcview.h PRE-CREATION
> shells/application/pmcview.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119027/diff/
>
>
> Testing
> -------
>
> correctly works, containment is added to config file and restored on startup
>
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119027/">https://git.reviewboard.kde.org/r/119027/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b5be331bd2fc95aac54b7abcfba0c8de0c1ed1df by Bhushan Shah to \
branch frameworks.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On June 30th, 2014, 9:52 a.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 9:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a basic application to load mediacenter shell,
Which loads shell package
Creates PlasmaQuick view to load Desktop.qml
And adds one containment in corona</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">correctly works, containment is added to config file and restored on \
startup</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f79e878)</span></li>
<li>shells/CMakeLists.txt <span style="color: grey">(9877ee3)</span></li>
<li>shells/application/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/application/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shells/application/plasmaquick/view.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/application/pmccorona.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/application/pmccorona.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/application/pmcview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shells/application/pmcview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119027/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic