[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118977: KSMServer: Do not autostart files
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-06-27 15:57:31
Message-ID: 20140627155731.11642.8043 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 27, 2014, 3:10 p.m., Rohan Garg wrote:
> > I applied it locally here and krunner still starts up twice.
>
> Rohan Garg wrote:
> So, krunner starting twice is another bug in session management, but \
> other apps like konsole only startup once after this patch
> Marco Martin wrote:
> is the rest up to date? now krunner should be started with autostart as \
> the rest
It seems that KRunner was started twice cause it being restored by the \
session manager and being started. I'll change krunner to ignore session \
management. Something similar to this - \
https://git.reviewboard.kde.org/r/118978/diff/#index_header
This patch is still needed because apps are started twice (ignore session \
management)
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118977/#review61099
-----------------------------------------------------------
On June 27, 2014, 2:59 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118977/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 2:59 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 335878
> https://bugs.kde.org/show_bug.cgi?id=335878
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> KSMServer: Do not autostart files
>
> Currently KLauncher is responsible for starting all of the autostart
> files. It intelligently starts only the files which should be started in
> the KDE environment.
>
> Once this is done, KLauncher then decides to also start all the files
> in the autostart folder, but does that without checking which should be
> started. I'm not sure why both KSMServer and KLauncher are overlaping
> and doing the same thing. But it seems that KLauncher is the correct
> place to do this. Specially since ksmserver uses kioclient5 in order to
> start the applications.
>
> BUG: 335878
>
>
> Diffs
> -----
>
> ksmserver/server.h 3d19118
> ksmserver/startup.cpp 11cc968
>
> Diff: https://git.reviewboard.kde.org/r/118977/diff/
>
>
> Testing
> -------
>
> Applications are now only started once.
>
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118977/">https://git.reviewboard.kde.org/r/118977/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On June 27th, 2014, 3:10 \
p.m. UTC, <b>Rohan Garg</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I applied it \
locally here and krunner still starts up twice.</pre> </blockquote>
<p>On June 27th, 2014, 3:35 p.m. UTC, <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">So, krunner starting twice is another bug in session \
management, but other apps like konsole only startup once after this \
patch</pre> </blockquote>
<p>On June 27th, 2014, 3:44 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">is the rest up to date? now krunner should be started with \
autostart as the rest</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems that \
KRunner was started twice cause it being restored by the session manager \
and being started. I'll change krunner to ignore session management. \
Something similar to this - \
https://git.reviewboard.kde.org/r/118978/diff/#index_header
This patch is still needed because apps are started twice (ignore session \
management)</pre> <br />
<p>- Vishesh</p>
<br />
<p>On June 27th, 2014, 2:59 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 2:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335878">335878</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> KSMServer: Do not autostart files
Currently KLauncher is responsible for starting all of the autostart
files. It intelligently starts only the files which should be started \
in the KDE environment.
Once this is done, KLauncher then decides to also start all the files
in the autostart folder, but does that without checking which should be
started. I'm not sure why both KSMServer and KLauncher are \
overlaping and doing the same thing. But it seems that KLauncher is the \
correct place to do this. Specially since ksmserver uses kioclient5 in \
order to start the applications.
BUG: 335878
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applications are now only started once.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/server.h <span style="color: grey">(3d19118)</span></li>
<li>ksmserver/startup.cpp <span style="color: grey">(11cc968)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118977/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic