'Re: Review Request 118972: Don't have all the Thmeme color properties in the public api'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118972: Don't have all the Thmeme color properties in the public api
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-06-27 13:09:50
Message-ID: 20140627130950.18724.53596 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118972/
-----------------------------------------------------------

(Updated June 27, 2014, 1:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Repository: plasma-framework

Description
-------

the color properties are remotely useful only when used from QML and risk to explode \
in number in the future, it's not a good thing for a public c++ api.

Also, they will become kinda deprecated as in largely replaced by the ColorRole api. \
Too late to remove those properties completely, but still last days to move them at \
least out of c++ api. (and in qml they could be removed in the future in a 2.1 \
version of the import while still being present in 2.0 if needed)

This moves the color properties is a theme subclass available only from QML (yes, it \
basically reintroduces the old themeproxy concept, but i don't think it was \
completely a good move to move everything in theme)

Diffs
-----

  src/declarativeimports/core/CMakeLists.txt e3d2f4e 
  src/declarativeimports/core/corebindingsplugin.cpp ebd9fd7 
  src/declarativeimports/core/quicktheme.h PRE-CREATION 
  src/declarativeimports/core/quicktheme.cpp PRE-CREATION 
  src/plasma/theme.h 0211f73 
  src/plasma/theme.cpp c193807 

Diff: https://git.reviewboard.kde.org/r/118972/diff/

Testing
-------

Thanks,

Marco Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118972/">https://git.reviewboard.kde.org/r/118972/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated June 27, 2014, 1:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the color properties are remotely useful only when used from QML and \
risk to explode in number in the future, it&#39;s not a good thing for a public c++ \
api.

Also, they will become kinda deprecated as in largely replaced by the ColorRole api. \
Too late to remove those properties completely, but still last days to move them at \
least out of c++ api. (and in qml they could be removed in the future in a 2.1 \
version of the import while still being present in 2.0 if needed)

This moves the color properties is a theme subclass available only from QML (yes, it \
basically reintroduces the old themeproxy concept, but i don&#39;t think it was \
completely a good move to move everything in theme) </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/CMakeLists.txt <span style="color: \
grey">(e3d2f4e)</span></li>

 <li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(ebd9fd7)</span></li>

 <li>src/declarativeimports/core/quicktheme.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/declarativeimports/core/quicktheme.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plasma/theme.h <span style="color: grey">(0211f73)</span></li>

 <li>src/plasma/theme.cpp <span style="color: grey">(c193807)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118972/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 