[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 118974: UserAccount KCM: Change the name using the AccountManager
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-06-27 11:25:51
Message-ID: 20140627112551.18724.95856 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118974/
-----------------------------------------------------------
Review request for Plasma.
Repository: kde-baseapps
Description
-------
UserAccount KCM: Change the name using the AccountManager
Instead of calling chfn, parsing its output (which depends on the
version of chfn which is present) and also additionally requires the
password.
This is also much more secure since we aren't storing the password in
memory.
Diffs
-----
kdepasswd/kcm/CMakeLists.txt ddb2ed6
kdepasswd/kcm/chfnprocess.h 9f962e2
kdepasswd/kcm/chfnprocess.cpp fca8e25
kdepasswd/kcm/main.cpp 25f9001
Diff: https://git.reviewboard.kde.org/r/118974/diff/
Testing
-------
Thanks,
Vishesh Handa
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118974/">https://git.reviewboard.kde.org/r/118974/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> UserAccount KCM: Change the name using the AccountManager
Instead of calling chfn, parsing its output (which depends on the
version of chfn which is present) and also additionally requires the
password.
This is also much more secure since we aren't storing the password in
memory.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdepasswd/kcm/CMakeLists.txt <span style="color: grey">(ddb2ed6)</span></li>
<li>kdepasswd/kcm/chfnprocess.h <span style="color: grey">(9f962e2)</span></li>
<li>kdepasswd/kcm/chfnprocess.cpp <span style="color: grey">(fca8e25)</span></li>
<li>kdepasswd/kcm/main.cpp <span style="color: grey">(25f9001)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118974/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic