'Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level c'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level c
From:       "Hugo Pereira Da Costa" <hugo.pereira () free ! fr>
Date:       2014-06-26 11:49:08
Message-ID: 20140626114908.26151.36039 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118763/#review61017
-----------------------------------------------------------

Ship it!

Ship It!

- Hugo Pereira Da Costa

On June 16, 2014, 2:07 p.m., Bernd Steinhauser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118763/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 2:07 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> No idea if kde-workspace is still the right group, if not, please change.
> 
> find_package(XCB) is called without specifying the required components. This leads \
> to linking to unused dependencies in case they are installed. 
> Since XCB is searched for in the top level cmake file in the repository, there is \
> no need to search for it again. The component required there (only base XCB) is \
> sufficient. Although, this should be sufficient to fix the deps problem, it makes \
> sense to link to XCB::XCB instead of ${XCB_LIBRARIES}, since the former is what is \
> actually needed. 
> 
> Diffs
> -----
> 
> kstyle/CMakeLists.txt 165b62a 
> liboxygen/CMakeLists.txt 0d1dd94 
> 
> Diff: https://git.reviewboard.kde.org/r/118763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Steinhauser
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118763/">https://git.reviewboard.kde.org/r/118763/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Hugo Pereira Da Costa</p>

<br />
<p>On June 16th, 2014, 2:07 p.m. UTC, Bernd Steinhauser wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace, Plasma and Hugo Pereira Da Costa.</div>
<div>By Bernd Steinhauser.</div>

<p style="color: grey;"><i>Updated June 16, 2014, 2:07 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No idea if kde-workspace is still the right group, if not, please \
change.

find_package(XCB) is called without specifying the required components. This leads to \
linking to unused dependencies in case they are installed.

Since XCB is searched for in the top level cmake file in the repository, there is no \
need to search for it again. The component required there (only base XCB) is \
sufficient. Although, this should be sufficient to fix the deps problem, it makes \
sense to link to XCB::XCB instead of ${XCB_LIBRARIES}, since the former is what is \
actually needed.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyle/CMakeLists.txt <span style="color: grey">(165b62a)</span></li>

 <li>liboxygen/CMakeLists.txt <span style="color: grey">(0d1dd94)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118763/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 