[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118896: Fix 2 data races in runnercontext, mention another one.
From: "Commit Hook" <null () kde ! org>
Date: 2014-06-25 22:54:05
Message-ID: 20140625225405.22754.92093 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118896/#review60987
-----------------------------------------------------------
This review has been submitted with commit 09dd2a2a20b7fcd5382e8b139e1843da4437cba9 \
by David Faure to branch master.
- Commit Hook
On June 25, 2014, 10:51 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118896/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 10:51 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Fix 2 data races in runnercontext, mention another one.
>
> Found by helgrinding krunner. Turns out helgrind lacks support for
> QReadWriteLock, but reading the code still made me found these.
>
>
> Diffs
> -----
>
> plasma/private/runnerjobs.cpp 6a8a7710f95adba38cc56c2d59393bfa3b123185
> plasma/runnercontext.cpp abd6a4bc7fca2a0d05f27c6601b658ff552307b3
>
> Diff: https://git.reviewboard.kde.org/r/118896/diff/
>
>
> Testing
> -------
>
> Typing various things into krunner.
>
> The main crash is still there though: baloo or xapian isn't reentrant; but that's \
> separate.
>
> Thanks,
>
> David Faure
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118896/">https://git.reviewboard.kde.org/r/118896/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 09dd2a2a20b7fcd5382e8b139e1843da4437cba9 by David Faure to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On June 25th, 2014, 10:51 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated June 25, 2014, 10:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix 2 data races in runnercontext, mention another one.
Found by helgrinding krunner. Turns out helgrind lacks support for
QReadWriteLock, but reading the code still made me found these.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Typing various things into krunner.
The main crash is still there though: baloo or xapian isn't reentrant; but \
that's separate.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/private/runnerjobs.cpp <span style="color: \
grey">(6a8a7710f95adba38cc56c2d59393bfa3b123185)</span></li>
<li>plasma/runnercontext.cpp <span style="color: \
grey">(abd6a4bc7fca2a0d05f27c6601b658ff552307b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118896/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic