'Re: Review Request 118937: DesktopView: Launch krunner on typing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118937: DesktopView: Launch krunner on typing
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-06-25 14:47:12
Message-ID: 20140625144712.7396.24948 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118937/#review60959
-----------------------------------------------------------

Ship it!

shell/desktopview.cpp
<https://git.reviewboard.kde.org/r/118937/#comment42460>

    Add some documentation like

    /*
    When a key is pressed on desktop when nothing else is active forward the key to krunner
    */

- David Edmundson

On June 25, 2014, 2:38 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118937/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 2:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 336692
>     https://bugs.kde.org/show_bug.cgi?id=336692
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is consistent with the behaviour in Plasma 4.
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt ed1348f 
>   shell/desktopview.h 1cc5881 
>   shell/desktopview.cpp a0e08ad 
> 
> Diff: https://git.reviewboard.kde.org/r/118937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118937/">https://git.reviewboard.kde.org/r/118937/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118937/diff/1/?file=284576#file284576line175" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/desktopview.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">175</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span \
class="n">activeFocusItem</span><span class="p">()</span> <span class="o">==</span> \
<span class="n">contentItem</span><span class="p">())</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add some \
documentation like

/*
When a key is pressed on desktop when nothing else is active forward the key to \
                krunner
*/</pre>
</div>
<br />

<p>- David Edmundson</p>

<br />
<p>On June 25th, 2014, 2:38 p.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated June 25, 2014, 2:38 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=336692">336692</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is consistent with the behaviour in Plasma 4. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/CMakeLists.txt <span style="color: grey">(ed1348f)</span></li>

 <li>shell/desktopview.h <span style="color: grey">(1cc5881)</span></li>

 <li>shell/desktopview.cpp <span style="color: grey">(a0e08ad)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118937/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 